Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Support AOT mode in GTK shell #18809

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Jun 4, 2020

As copied from #18423

@auto-assign auto-assign bot requested a review from gw280 June 4, 2020 03:58
@robert-ancell robert-ancell requested review from stuartmorgan-g and removed request for gw280 June 4, 2020 03:58
@robert-ancell
Copy link
Contributor Author

Note this breaks the existing API for dart_project_new() - please check if the new API makes more sense.

@robert-ancell robert-ancell force-pushed the linux-shell-aot branch 2 times, most recently from cea8833 to 7c693ee Compare June 4, 2020 23:01
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than restoring most of the header comment as noted.

Simplify FlDartProject by removing the path arguments - we'll assume that it's
in the standard bundle layout and add new methods later if we need to support
other cases.
Copy link
Contributor

@MarcusTomlinson MarcusTomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm late to the party. LGTM.

@robert-ancell robert-ancell merged commit dfdd88d into flutter:master Jun 8, 2020
@robert-ancell robert-ancell deleted the linux-shell-aot branch June 8, 2020 01:18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2020
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 8, 2020
cg021 pushed a commit to cg021/engine that referenced this pull request Jun 9, 2020
Simplify FlDartProject by removing the path arguments - we'll assume that it's
in the standard bundle layout and add new methods later if we need to support
other cases.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants