This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Win32, Keyboard] Lift redispatching to messages, via SendMessage. #31200
+337
−511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkwingsmt
changed the title
gspencergoog
approved these changes
Feb 2, 2022
| // The 25th bit of the LParam. | ||
| // | ||
| // Some messages are sent bit25 set. It's meaning is yet unknown. | ||
| bool bit25 = 0; |
dkwingsmt
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2022
|
I made some tests on master branch now, and after pressing Enter, or reading a barcode, that sends a Enter key event on finish, only the keys enter and backspace keep working, all other keys stop working, on all text fields in my application. |
ghost
mentioned this pull request
|
@vinicios-cervantes Is it still reproducing on master? Can you open an new issue for it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, event redispatching is checked at the start of
OnKey, and events are redispatched withSendInput. With this PR, event redispatching is checked at the start ofHandleMessage, and events are redispatched withSendMessage.This change has the following benefits:
SendMessagekeeps the exact content of messages, instead of having them twisted bySendInput. Notably, this allows redispatching SYS messages and character messages with diacritics.HandleMessagelevel makes filtering much more precise, including their direct result.Since
SendMessageis processed synchronously, instantly, without going through the message queue. This means that redispatched messages will no longer be mistaken as real messages, or vice versa.Additionally, since it is no longer needed to convert between inputs and messages, or to put inputs in a queue, the mock classes have been greatly simplified.
This PR fixes flutter/flutter#84210, fixes flutter/flutter#95479, fixes flutter/flutter#88388, and fixes flutter/flutter#87843.
This PR is likely a fix to flutter/flutter#77179 and flutter/flutter#91482, since I can't reproduce them any more. But removing their temporary code will be done in a separate PR for the convenience of reference and revert.
This is one of the many steps to refactor the windows keyboard system.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.