This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Win32, Keyboard] Resume redispatching ShiftRight key down and DeadKey messages #31459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix embedder test Implement and finish tests
RedispatchedMessageCountAndClear Add more tests. Problem with `handled` patching. Remove ComputeEventHash
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
dkwingsmt
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2022
…d DeadKey messages (flutter/engine#31459)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, ShiftRight key down messages and DeadKey messages will be redispatched.
Redispatching of ShiftRight key down messages were turned off by flutter/flutter#81674, while redispatching of dead key messages were turned off by #28125. With #31200 changing redispatching to
SendMessage, the problems caused bySendInputseem to have gone, and according to manual testing it's safe to remove these special cases.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.