[Android 16] Bumped Android Defaults in Example Plugins #9241

jesswrd · 2025-05-12T03:12:57Z

Ensured the example plugin apps on Android work on Android API 36 by updating configurations and sucessfully running flutter build apk (means the app can successfully build + all dependencies are resolvable). For compatibility with Android API 36, the example plugin apps on Android should have the following configurations:

targetSdk: 36
compileSdk: 36
AGP version: 8.9.1
Gradle version: 8.11.1

Most packages no longer require a manual bump of targetSdk and compileSdk due to usage of values from Flutter Gradle Plugin. Below is a list of example plugin apps on Android:

Partially Adresses flutter/flutter#163071

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

jesswrd · 2025-05-19T16:01:12Z

Looks like the new toolchain is triggering some new lints that will need to be resolved.

done

reidbaker · 2025-05-19T16:16:11Z

For posterity, How did you update these projects? Did you use the android studio tool for updating the project or did you do something else?

I updated them manually. The values were dervied from the sdk 36 minimums from android docs here. I think to use the AGP upgrade tool, you would have to open each android project separately.

Ok I think it might be valuable to pick one and use the android studio tool to see what they update. It is pretty common for there to be flags or files that also get modified that are not required but are best practices. If nothing changes except for what you have in this pr great, if not then we should look at the difference and see if it is a change that should be applied more broadly.

reidbaker · 2025-05-19T16:16:21Z

For posterity, How did you update these projects? Did you use the android studio tool for updating the project or did you do something else?

I updated them manually. The values were dervied from the sdk 36 minimums from android docs here. I think to use the AGP upgrade tool, you would have to open each android project separately.

Ok I think it might be valuable to pick one and use the android studio tool to see what they update. It is pretty common for there to be flags or files that also get modified that are not required but are best practices. If nothing changes except for what you have in this pr great, if not then we should look at the difference and see if it is a change that should be applied more broadly.

NON blocking comment.

jesswrd · 2025-05-19T16:17:45Z

For posterity, How did you update these projects? Did you use the android studio tool for updating the project or did you do something else?

I updated them manually. The values were dervied from the sdk 36 minimums from android docs here. I think to use the AGP upgrade tool, you would have to open each android project separately.

Ok I think it might be valuable to pick one and use the android studio tool to see what they update. It is pretty common for there to be flags or files that also get modified that are not required but are best practices. If nothing changes except for what you have in this pr great, if not then we should look at the difference and see if it is a change that should be applied more broadly.

I did. I ended up using the command Camille suggested for Gradle. It caught some example packages I didn't catch (rfw specifically). Everything should be accounted for.

camsim99 · 2025-05-20T18:12:24Z

I actually didn't see you could use that command to update Gradle on my first pass. I just tried it and it works well. It doesn't look like the update dependency command includes updating AGP for example apps. ~~May be worthwhile to add.~~ jk it's already a todo.

Filed flutter/flutter#169151 so we remember :)

stuartmorgan-g

LGTM, but what's the reason for suppressing the UseRequiresApi lint violations instead of changing to match the lint's guidance?

jesswrd · 2025-05-22T23:38:29Z

LGTM, but what's the reason for suppressing the UseRequiresApi lint violations instead of changing to match the lint's guidance?

I suppressed the lint violations because I didn't want to introduce any potential behavorial changes in this PR. @RequiresApi has strict caller requirements. It should only be used when you can demonstrate you need to use it. I can file an issue and do this in a separate PR.

…9264) > [!NOTE] > This should land after #9241, which should safely bumps the AGP version of this plugin's example app higher than this PR does. Fixes flutter/flutter#168551 by implementing the `enableAudio` camera setting for video recording. Also: - Bumps CameraX library version to the latest version,`1.5.0-beta01` (to use a new CameraX method in this implementation) - Bumps the plugin AGP version to that which `1.5.0-beta01` requires (`8.6.0`) - Bumps the plugin's example app AGP version to that which `1.5.0-beta01` requires (`8.6.0`) -- will be overridden by #9241 - Corrects the example app to use the `enableAudio` setting just as the app-facing camera widget does - Adds lint errors caused by the **pigeon generated** `CameraXLibrary.g.kt` file caused by the `1.5.0-beta01` bump to a `lint-baseline.xml` file (all the errors are [`UnsageOptInUsage`](https://googlesamples.github.io/android-custom-lint-rules/checks/UnsafeOptInUsageError.md.html) lints caused by the plugin's [`ExperimentalCamera2Interop`](https://developer.android.com/reference/androidx/camera/camera2/interop/ExperimentalCamera2Interop) usage which is unrelated to this PR) ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…kages#9241)

flutter/packages@af0b9a9...6eebe72 2025-05-27 [email protected] [flutter_lints] Bump lints dependency to 6.0.0 and bump package to 6.0.0 (flutter/packages#9108) 2025-05-26 [email protected] Roll Flutter from 60050a0 to 4372bfb (6 revisions) (flutter/packages#9322) 2025-05-26 [email protected] [video_player_android] Add note about Android platform views known issue (flutter/packages#9312) 2025-05-24 [email protected] Roll Flutter from 85564cb to 60050a0 (17 revisions) (flutter/packages#9318) 2025-05-23 [email protected] [camera_android_camerax] Implement `enableAudio` for video recording (flutter/packages#9264) 2025-05-23 [email protected] [video_player_android] isBuffering flag always return true after calling seekTo method - fixed (flutter/packages#9198) 2025-05-23 [email protected] [camera,video_player] replace onSurfaceDestroyed with onSurfaceCleanup (flutter/packages#9316) 2025-05-23 [email protected] [camera,video_player] Update Android to 3.29 minimum (flutter/packages#9317) 2025-05-23 [email protected] Roll Flutter from 33cdd8e to 85564cb (39 revisions) (flutter/packages#9315) 2025-05-23 [email protected] Update repo for 3.32 stable (flutter/packages#9311) 2025-05-23 [email protected] [camera_avfoundation] Correct pigeon configuration output paths (flutter/packages#9313) 2025-05-23 [email protected] [process] Remove from the repository (flutter/packages#9310) 2025-05-22 [email protected] Ensure Example Packages Work on Android API 36 (flutter/packages#9241) 2025-05-22 [email protected] Roll Flutter (stable) from c236373 to be698c4 (1274 revisions) (flutter/packages#9300) 2025-05-22 [email protected] Remove CODEOWNER for generated iOS files (flutter/packages#9272) 2025-05-22 [email protected] [google_maps_flutter] Removes unnecessary parentheses (flutter/packages#9273) 2025-05-21 [email protected] Rebalance Android plugin CODEOWNERS (flutter/packages#9298) 2025-05-21 [email protected] Roll Flutter from 9a78af5 to 33cdd8e (60 revisions) (flutter/packages#9305) 2025-05-21 [email protected] [ci] Update repository for 3.29 release (flutter/packages#9270) 2025-05-21 [email protected] Ignore .cxx/ directories (flutter/packages#9268) 2025-05-21 [email protected] [video_player] Skip some integration tests on web (flutter/packages#9302) 2025-05-21 [email protected] [webview_flutter] Adds support to respond to recoverable SSL certificate errors (flutter/packages#9150) 2025-05-19 [email protected] [camera_android_camerax] Swap out `BroadcastReceiver` for `OrientationEventListener` (flutter/packages#9261) 2025-05-19 [email protected] [video_player_android] Fix incorrect dimensions swap (flutter/packages#9199) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Ensured the example plugin apps on Android work on Android API 36 by updating configurations and sucessfully running `flutter build apk` (means the app can successfully build + all dependencies are resolvable). For compatibility with Android API 36, the example plugin apps on Android should have the following configurations: `targetSdk`: 36 `compileSdk`: 36 AGP version: 8.9.1 Gradle version: 8.11.1 Most packages no longer require a manual bump of `targetSdk` and `compileSdk` due to usage of values from Flutter Gradle Plugin. Below is a list of example plugin apps on Android: Partially Adresses flutter/flutter#163071 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…lutter#9264) > [!NOTE] > This should land after flutter#9241, which should safely bumps the AGP version of this plugin's example app higher than this PR does. Fixes flutter/flutter#168551 by implementing the `enableAudio` camera setting for video recording. Also: - Bumps CameraX library version to the latest version,`1.5.0-beta01` (to use a new CameraX method in this implementation) - Bumps the plugin AGP version to that which `1.5.0-beta01` requires (`8.6.0`) - Bumps the plugin's example app AGP version to that which `1.5.0-beta01` requires (`8.6.0`) -- will be overridden by flutter#9241 - Corrects the example app to use the `enableAudio` setting just as the app-facing camera widget does - Adds lint errors caused by the **pigeon generated** `CameraXLibrary.g.kt` file caused by the `1.5.0-beta01` bump to a `lint-baseline.xml` file (all the errors are [`UnsageOptInUsage`](https://googlesamples.github.io/android-custom-lint-rules/checks/UnsafeOptInUsageError.md.html) lints caused by the plugin's [`ExperimentalCamera2Interop`](https://developer.android.com/reference/androidx/camera/camera2/interop/ExperimentalCamera2Interop) usage which is unrelated to this PR) ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

Ensured the example plugin apps on Android work on Android API 36 by updating configurations and sucessfully running `flutter build apk` (means the app can successfully build + all dependencies are resolvable). For compatibility with Android API 36, the example plugin apps on Android should have the following configurations: `targetSdk`: 36 `compileSdk`: 36 AGP version: 8.9.1 Gradle version: 8.11.1 Most packages no longer require a manual bump of `targetSdk` and `compileSdk` due to usage of values from Flutter Gradle Plugin. Below is a list of example plugin apps on Android: Partially Adresses flutter/flutter#163071 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…lutter#9264) > [!NOTE] > This should land after flutter#9241, which should safely bumps the AGP version of this plugin's example app higher than this PR does. Fixes flutter/flutter#168551 by implementing the `enableAudio` camera setting for video recording. Also: - Bumps CameraX library version to the latest version,`1.5.0-beta01` (to use a new CameraX method in this implementation) - Bumps the plugin AGP version to that which `1.5.0-beta01` requires (`8.6.0`) - Bumps the plugin's example app AGP version to that which `1.5.0-beta01` requires (`8.6.0`) -- will be overridden by flutter#9241 - Corrects the example app to use the `enableAudio` setting just as the app-facing camera widget does - Adds lint errors caused by the **pigeon generated** `CameraXLibrary.g.kt` file caused by the `1.5.0-beta01` bump to a `lint-baseline.xml` file (all the errors are [`UnsageOptInUsage`](https://googlesamples.github.io/android-custom-lint-rules/checks/UnsafeOptInUsageError.md.html) lints caused by the plugin's [`ExperimentalCamera2Interop`](https://developer.android.com/reference/androidx/camera/camera2/interop/ExperimentalCamera2Interop) usage which is unrelated to this PR) ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

ekuleshov · 2025-07-20T18:49:26Z

packages/camera/camera_android/android/build.gradle

@@ -31,7 +31,7 @@ buildFeatures {
        buildConfig true
    }
    namespace 'io.flutter.plugins.camera'
-    compileSdk = flutter.compileSdkVersion
+    compileSdk = 36


@jesswrd @stuartmorgan-g is this an intentional change?
Why do this only for the camera_android and not for any other plugins?
This change forces plugin users to use compileSdk 36 for all other Android plugins.

Talked to @jesswrd and determined this was a mistake! We'll undo it. Thanks for the heads up!

@jesswrd I thought I had a test that verified flutter.compileSdkVersion was used.

packages/script/tool/lib/src/gradle_check_command.dart

Line 449 in c5e8c82

if (compileSdkLine.contains('flutter.compileSdkVersion')) {

Maybe update that test to prevent this from happening.

Actually enforcing that it's used could be tricky; couldn't we potentially need to set this higher than compileSdkVersion in order to (conditionally at runtime) adopt a new API?

probably not for compileSdkVersion but possibly for targetSdkVersion or minSdkVersion. Compile normally should be the highest published value and does not change the behavior of running apps.

https://github.com/flutter/flutter/blob/f277865a8e6d1a126f11acd6759e974b037abdf2/docs/contributing/Android-API-And-Related-Versions.md?plain=1#L17

Compile normally should be the highest published value

Right, but we support multiple versions of Flutter, and the flutter.compileSdkVersion for a given version is a fixed value that does not change with the reality of what the highest published value is.

The scenario I am thinking of is:

Flutter stable, N-1, and N-2 have a flutter.compileSdkVersion of X.

SDK version X+1 comes out.

It's adopted as flutter.compileSdkVersion on master.

We want to use some API (with appropriate runtime checks) that was introduced in X+1 in plugin foo.

Isn't the desired action in that case to temporarily change foo's compileSdk to X+1, so that we can use the new API without waiting for it to filter to stable (and have us drop N-1 and N-2 support just for that)?

reidbaker · 2025-07-23T19:32:38Z

yeah that is fair didnt think about version skew across versions of flutter when I should have.

…

On Wed, Jul 23, 2025 at 3:00 PM stuartmorgan-g ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/camera/camera_android/android/build.gradle <#9241 (comment)>: > @@ -31,7 +31,7 @@ buildFeatures { buildConfig true } namespace 'io.flutter.plugins.camera' - compileSdk = flutter.compileSdkVersion + compileSdk = 36 Compile normally should be the highest published value Right, but we support multiple versions of Flutter, and the flutter.compileSdkVersion for a given version is a fixed value that does not change with the reality of what the highest published value is. The scenario I am thinking of is: - Flutter stable, N-1, and N-2 have a flutter.compileSdkVersion of X. - SDK version X+1 comes out. - It's adopted as flutter.compileSdkVersion on master. - We want to use some API (with appropriate runtime checks) that was introduced in X+1 in plugin foo. Isn't the desired action in that case to temporarily change foo's compileSdk to X+1, so that we can use the new API without waiting for it to filter to stable (and have us drop N-1 and N-2 support just for that)? — Reply to this email directly, view it on GitHub <#9241 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIDVLAMZCEUNBD7T7GL7ET3J7LVZAVCNFSM6AAAAAB44YEKMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANBYGY2DMNZZGU> . You are receiving this because your review was requested.Message ID: <flutter/packages/pull/9241/review/3048646795 ***@***.*** com>

jesswrd · 2025-07-23T22:06:12Z

Compile normally should be the highest published value

Right, but we support multiple versions of Flutter, and the flutter.compileSdkVersion for a given version is a fixed value that does not change with the reality of what the highest published value is.

The scenario I am thinking of is:

Flutter stable, N-1, and N-2 have a flutter.compileSdkVersion of X.

SDK version X+1 comes out.

It's adopted as flutter.compileSdkVersion on master.

We want to use some API (with appropriate runtime checks) that was introduced in X+1 in plugin foo.

Isn't the desired action in that case to temporarily change foo's compileSdk to X+1, so that we can use the new API without waiting for it to filter to stable (and have us drop N-1 and N-2 support just for that)?

@reidbaker Oops just saw this. I made the change to the check_gradle_command that enforces usage of flutter.compileSdkVersion here. Stuart's concern is valid, but I do think it is useful to enforce or at least prompt to use flutter.compileSdkVersion unless someone explicitly wants to utilize a super new version. Maybe there can be a warning instead of an outright failure? Thoughts?

stuartmorgan-g · 2025-07-24T13:05:50Z

Maybe there can be a warning instead of an outright failure? Thoughts?

There is unfortunately no way to prominently surface warnings in the GitHub UI, and people almost never look at full CI output unless something is wrong or they are actively checking for a specific thing, so printing warning output for something like this is, in practice, essentially useless.

If the goal is to enforce it as a general rule but allow people to override it if they really mean to, the only workable pattern we've developed for that is the override: * labels. In theory we could add another one for this, although it would require doing line-level diffing in the check so that the label was only needed when actually changing that line.

first check

44ffc2f

github-actions bot added the p: flutter_svg label May 12, 2025

jesswrd changed the title ~~[WIP] Ensure Packages Works on SDK 36~~ [WIP] Ensure Example Packages Works on SDK 36 May 12, 2025

jesswrd changed the title ~~[WIP] Ensure Example Packages Works on SDK 36~~ [WIP] Ensure Example Packages Work on SDK 36 May 12, 2025

jesswrd changed the title ~~[WIP] Ensure Example Packages Work on SDK 36~~ [WIP] Ensure Example Packages Work on Android API 36 May 12, 2025

jesswrd and others added 2 commits May 12, 2025 15:08

Merge branch 'main' into update-packages-to-36

ea32acd

batch of 5 plugins confirmed to work on 36

242cd5e

github-actions bot added p: flutter_plugin_android_lifecycle p: path_provider platform-android p: webview_flutter labels May 12, 2025

jesswrd added 2 commits May 14, 2025 16:33

batch of 5 more plugins confirmed to work on 36

b14661a

update gradle versions of packages with gradle wrappers in android/app

67d24ab

github-actions bot added p: file_selector p: google_sign_in labels May 14, 2025

5 more example plugins work on api 36

2352fcb

github-actions bot added p: camera p: local_auth p: interactive_media_ads Plugin for IMA SDK labels May 15, 2025

5 more example plugins work on api 36

c1d104b

github-actions bot added p: video_player p: url_launcher labels May 15, 2025

6 more example plugins work on api 36

3a4ac4e

github-actions bot added p: google_maps_flutter p: image_picker p: in_app_purchase labels May 15, 2025

7 more example plugins work on api 36

bb4dd7a

github-actions bot added p: extension_google_sign_in_as_googleapis_auth p: go_router p: animations labels May 15, 2025

jesswrd added 2 commits May 19, 2025 18:50

bumped a few strays

e992a49

added newline to all example gradle-wrapper.properties file

b686813

jesswrd requested a review from Hixie as a code owner May 19, 2025 11:18

github-actions bot added the p: rfw Remote Flutter Widgets label May 19, 2025

Merge branch 'main' into update-packages-to-36

bf9630c

This was referenced May 20, 2025

[camera_android_camerax] Implement enableAudio for video recording #9264

Merged

Add an Android Gradle Plugin option to the flutter/packages update-dependency tool flutter/flutter#169151

Open

stuartmorgan-g approved these changes May 22, 2025

View reviewed changes

jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2025

auto-submit bot merged commit fe5dd86 into flutter:main May 22, 2025
82 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2025

fe5dd86d6 Ensure Example Packages Work on Android API 36 (flutter/pac…

ac84b91

…kages#9241)

engine-flutter-autoroll mentioned this pull request May 27, 2025

Roll Packages from af0b9a941dd3 to 6eebe72ca397 (24 revisions) flutter/flutter#169514

Merged

jesswrd changed the title ~~Ensure Example Packages Work on Android API 36~~ [Android 16] Bumped Android Defaults in Example Plugins Jun 10, 2025

jesswrd mentioned this pull request Jun 10, 2025

☔ Android 16 api 36 topline tracking bug flutter/flutter#163071

Open

23 tasks

ekuleshov reviewed Jul 20, 2025

View reviewed changes

[Android 16] Bumped Android Defaults in Example Plugins #9241

[Android 16] Bumped Android Defaults in Example Plugins #9241

Uh oh!

Conversation

jesswrd commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

jesswrd commented May 19, 2025

Uh oh!

reidbaker commented May 19, 2025

Uh oh!

reidbaker commented May 19, 2025

Uh oh!

jesswrd commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camsim99 commented May 20, 2025

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

jesswrd commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ekuleshov Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

camsim99 Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reidbaker Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reidbaker Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker commented Jul 23, 2025 via email

Uh oh!

jesswrd commented Jul 23, 2025

Uh oh!

stuartmorgan-g commented Jul 24, 2025

Uh oh!

Uh oh!

jesswrd commented May 12, 2025 •

edited

Loading

jesswrd commented May 19, 2025 •

edited

Loading

jesswrd commented May 22, 2025 •

edited

Loading

camsim99 Jul 23, 2025 •

edited

Loading

stuartmorgan-g Jul 23, 2025 •

edited

Loading