[camera_android_camerax] Implement `enableAudio` for video recording #9264

camsim99 · 2025-05-16T16:48:00Z

Note

This should land after #9241, which should safely bumps the AGP version of this plugin's example app higher than this PR does.

Fixes flutter/flutter#168551 by implementing the enableAudio camera setting for video recording. Also:

Bumps CameraX library version to the latest version,1.5.0-beta01 (to use a new CameraX method in this implementation)
Bumps the plugin AGP version to that which 1.5.0-beta01 requires (8.6.0)
Bumps the plugin's example app AGP version to that which 1.5.0-beta01 requires (8.6.0) -- will be overridden by [Android 16] Bumped Android Defaults in Example Plugins #9241
Corrects the example app to use the enableAudio setting just as the app-facing camera widget does
Adds lint errors caused by the pigeon generated CameraXLibrary.g.kt file caused by the 1.5.0-beta01 bump to a lint-baseline.xml file (all the errors are UnsageOptInUsage lints caused by the plugin's ExperimentalCamera2Interop usage which is unrelated to this PR)

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

camsim99 · 2025-05-20T18:01:03Z

packages/camera/camera_android_camerax/android/build.gradle

@@ -57,16 +57,17 @@ android {
        }
    }

-    lintOptions {
+    lint {


lintOptions is deprecated!

bparrishMines · 2025-05-21T20:33:20Z

...droid_camerax/android/src/main/java/io/flutter/plugins/camerax/PendingRecordingProxyApi.java

@@ -25,6 +27,19 @@ public ProxyApiRegistrar getPigeonRegistrar() {
    return (ProxyApiRegistrar) super.getPigeonRegistrar();
  }

+  @NonNull
+  @Override
+  public PendingRecording withAudioEnabled(PendingRecording pigeonInstance, boolean initialMuted) {


Just to clarify, withAudioEnabled(true) disables audio and withAudioEnabled(false) enables audio? I'm confused by the parameter name being initialMuted.

Lol yeah it's confusing.

I made this mirror PendingRecording.withAudioEnabled where initialMuted == true means that you want to initialize the recording as being muted/audio disabled, so withAudioEnabled(true) disables audio, withAudioEnabled(false) enables audio.

bparrishMines

LGTM

auto-submit · 2025-05-23T17:08:53Z

autosubmit label was removed for flutter/packages/9264, because Pull request flutter/packages/9264 is not in a mergeable state.

…recording (flutter/packages#9264)

flutter/packages@af0b9a9...6eebe72 2025-05-27 [email protected] [flutter_lints] Bump lints dependency to 6.0.0 and bump package to 6.0.0 (flutter/packages#9108) 2025-05-26 [email protected] Roll Flutter from 60050a0 to 4372bfb (6 revisions) (flutter/packages#9322) 2025-05-26 [email protected] [video_player_android] Add note about Android platform views known issue (flutter/packages#9312) 2025-05-24 [email protected] Roll Flutter from 85564cb to 60050a0 (17 revisions) (flutter/packages#9318) 2025-05-23 [email protected] [camera_android_camerax] Implement `enableAudio` for video recording (flutter/packages#9264) 2025-05-23 [email protected] [video_player_android] isBuffering flag always return true after calling seekTo method - fixed (flutter/packages#9198) 2025-05-23 [email protected] [camera,video_player] replace onSurfaceDestroyed with onSurfaceCleanup (flutter/packages#9316) 2025-05-23 [email protected] [camera,video_player] Update Android to 3.29 minimum (flutter/packages#9317) 2025-05-23 [email protected] Roll Flutter from 33cdd8e to 85564cb (39 revisions) (flutter/packages#9315) 2025-05-23 [email protected] Update repo for 3.32 stable (flutter/packages#9311) 2025-05-23 [email protected] [camera_avfoundation] Correct pigeon configuration output paths (flutter/packages#9313) 2025-05-23 [email protected] [process] Remove from the repository (flutter/packages#9310) 2025-05-22 [email protected] Ensure Example Packages Work on Android API 36 (flutter/packages#9241) 2025-05-22 [email protected] Roll Flutter (stable) from c236373 to be698c4 (1274 revisions) (flutter/packages#9300) 2025-05-22 [email protected] Remove CODEOWNER for generated iOS files (flutter/packages#9272) 2025-05-22 [email protected] [google_maps_flutter] Removes unnecessary parentheses (flutter/packages#9273) 2025-05-21 [email protected] Rebalance Android plugin CODEOWNERS (flutter/packages#9298) 2025-05-21 [email protected] Roll Flutter from 9a78af5 to 33cdd8e (60 revisions) (flutter/packages#9305) 2025-05-21 [email protected] [ci] Update repository for 3.29 release (flutter/packages#9270) 2025-05-21 [email protected] Ignore .cxx/ directories (flutter/packages#9268) 2025-05-21 [email protected] [video_player] Skip some integration tests on web (flutter/packages#9302) 2025-05-21 [email protected] [webview_flutter] Adds support to respond to recoverable SSL certificate errors (flutter/packages#9150) 2025-05-19 [email protected] [camera_android_camerax] Swap out `BroadcastReceiver` for `OrientationEventListener` (flutter/packages#9261) 2025-05-19 [email protected] [video_player_android] Fix incorrect dimensions swap (flutter/packages#9199) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

… objects when app is under memory pressure (#9287) ~~*Note:* Waiting on #9264 to land and to regenerate baseline file with.~~ This bumps `pigeon` to `25.3.2` and regenerates the code to fix a bug where native objects were getting garbage collected prematurely. See flutter/flutter#168531 Fixes flutter/flutter#152763 ## Pre-Review Checklist - [s] All existing and new tests are passing. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…lutter#9264) > [!NOTE] > This should land after flutter#9241, which should safely bumps the AGP version of this plugin's example app higher than this PR does. Fixes flutter/flutter#168551 by implementing the `enableAudio` camera setting for video recording. Also: - Bumps CameraX library version to the latest version,`1.5.0-beta01` (to use a new CameraX method in this implementation) - Bumps the plugin AGP version to that which `1.5.0-beta01` requires (`8.6.0`) - Bumps the plugin's example app AGP version to that which `1.5.0-beta01` requires (`8.6.0`) -- will be overridden by flutter#9241 - Corrects the example app to use the `enableAudio` setting just as the app-facing camera widget does - Adds lint errors caused by the **pigeon generated** `CameraXLibrary.g.kt` file caused by the `1.5.0-beta01` bump to a `lint-baseline.xml` file (all the errors are [`UnsageOptInUsage`](https://googlesamples.github.io/android-custom-lint-rules/checks/UnsafeOptInUsageError.md.html) lints caused by the plugin's [`ExperimentalCamera2Interop`](https://developer.android.com/reference/androidx/camera/camera2/interop/ExperimentalCamera2Interop) usage which is unrelated to this PR) ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

… objects when app is under memory pressure (flutter#9287) ~~*Note:* Waiting on flutter#9264 to land and to regenerate baseline file with.~~ This bumps `pigeon` to `25.3.2` and regenerates the code to fix a bug where native objects were getting garbage collected prematurely. See flutter/flutter#168531 Fixes flutter/flutter#152763 ## Pre-Review Checklist - [s] All existing and new tests are passing. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

camsim99 added 2 commits May 16, 2025 07:31

add base changes

3c852de

add tests, fixes

cca1467

github-actions bot added p: camera platform-android labels May 16, 2025

camsim99 added 6 commits May 19, 2025 14:49

add baseline lint file for generated code

3cc6ad3

bump version

8a0edb9

format kotlin file

bd0a0e1

Merge remote-tracking branch 'upstream/main' into camx_audio

f52f501

self review

5b8f2ce

fix PR

827f83c

camsim99 commented May 20, 2025

View reviewed changes

camsim99 mentioned this pull request May 20, 2025

[camera_android_camerax] Fixes premature garbage collection of native objects when app is under memory pressure #9287

Merged

10 tasks

camsim99 marked this pull request as ready for review May 20, 2025 18:33

camsim99 requested review from bparrishMines, jesswrd and a team May 20, 2025 18:33

bparrishMines reviewed May 21, 2025

View reviewed changes

bparrishMines approved these changes May 21, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into camx_audio

5e5cf84

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

camsim99 added 5 commits May 23, 2025 10:11

Merge remote-tracking branch 'upstream/main' into camx_audio

2d65185

Merge remote-tracking branch 'upstream/main' into camx_audio

ba2a945

format?

a49d337

new format for all touched files

578521b

try patch for format

9ac1356

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

auto-submit bot merged commit 62f38a1 into flutter:main May 23, 2025
81 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2025

62f38a1ab [camera_android_camerax] Implement enableAudio for video …

0343565

…recording (flutter/packages#9264)

engine-flutter-autoroll mentioned this pull request May 27, 2025

Roll Packages from af0b9a941dd3 to 6eebe72ca397 (24 revisions) flutter/flutter#169514

Merged

camsim99 mentioned this pull request May 29, 2025

Upgrade dependency of camera_android_camerax to support 16 KB memory page size flutter/flutter#159260

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[camera_android_camerax] Implement `enableAudio` for video recording #9264

[camera_android_camerax] Implement `enableAudio` for video recording #9264

Uh oh!

camsim99 commented May 16, 2025 •

edited

Loading

Uh oh!

camsim99 May 20, 2025

Uh oh!

bparrishMines May 21, 2025

Uh oh!

camsim99 May 21, 2025

Uh oh!

bparrishMines left a comment

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

Uh oh!

Uh oh!

[camera_android_camerax] Implement enableAudio for video recording #9264

[camera_android_camerax] Implement enableAudio for video recording #9264

Uh oh!

Conversation

camsim99 commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

camsim99 May 20, 2025

Choose a reason for hiding this comment

Uh oh!

bparrishMines May 21, 2025

Choose a reason for hiding this comment

Uh oh!

camsim99 May 21, 2025

Choose a reason for hiding this comment

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

Uh oh!

Uh oh!

[camera_android_camerax] Implement `enableAudio` for video recording #9264

[camera_android_camerax] Implement `enableAudio` for video recording #9264

camsim99 commented May 16, 2025 •

edited

Loading