Skip to content

feat(replay/v9): Deprecate _experiments.autoFlushOnFeedback #17219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jul 29, 2025

Flushing on feedback widget opening is better than on submit as you get more relevant replay context, so we are going to make this the default behavior and deprecate the configuration option. The option will be removed in v10.

This feature works pretty well so we are going to make this the default behavior and deprecate the settings. We should remove this in v10.
@billyvg billyvg marked this pull request as ready for review July 29, 2025 22:21
@billyvg billyvg requested a review from a team as a code owner July 29, 2025 22:21
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.79 kB - -
@sentry/browser - with treeshaking flags 22.36 kB - -
@sentry/browser (incl. Tracing) 39.66 kB - -
@sentry/browser (incl. Tracing, Replay) 77.77 kB -0.06% -40 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.56 kB -0.07% -42 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 82.46 kB -0.05% -41 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 94.56 kB -0.05% -39 B 🔽
@sentry/browser (incl. Feedback) 40.48 kB - -
@sentry/browser (incl. sendFeedback) 28.48 kB - -
@sentry/browser (incl. FeedbackAsync) 33.37 kB - -
@sentry/react 25.55 kB - -
@sentry/react (incl. Tracing) 41.62 kB - -
@sentry/vue 28.24 kB - -
@sentry/vue (incl. Tracing) 41.45 kB - -
@sentry/svelte 23.81 kB - -
CDN Bundle 25.18 kB - -
CDN Bundle (incl. Tracing) 39.42 kB - -
CDN Bundle (incl. Tracing, Replay) 75.39 kB -0.05% -35 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 80.86 kB -0.05% -35 B 🔽
CDN Bundle - uncompressed 73.45 kB - -
CDN Bundle (incl. Tracing) - uncompressed 116.86 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 230.97 kB -0.05% -93 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.79 kB -0.04% -93 B 🔽
@sentry/nextjs (client) 43.66 kB - -
@sentry/sveltekit (client) 40.08 kB - -
@sentry/node 169.17 kB - -
@sentry/node - without tracing 100.31 kB - -
@sentry/aws-serverless 128.47 kB - -

View base workflow run

@AbhiPrasad
Copy link
Member

Gonna merge this in because we have another v9 release incoming

@AbhiPrasad AbhiPrasad merged commit c58e1c6 into v9 Jul 31, 2025
258 of 260 checks passed
@AbhiPrasad AbhiPrasad deleted the billy/feat-replay-v9-deprecate-experiment-flush-feedback branch July 31, 2025 12:00
andreiborza pushed a commit that referenced this pull request Jul 31, 2025
…fault (#17220)

Flushing on feedback widget opening is better than on submit as you get
more relevant replay context, so we are going to make this the default
behavior and remove the configuration option. This is deprecated in
#17219

---------

Co-authored-by: Charly Gomez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants