-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(replay)!: Promote _experiments.autoFlushOnFeedback
option as default
#17220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andreiborza
merged 3 commits into
develop
from
billy/feat-replay-remove-experiment-auto-flush-feedback
Jul 31, 2025
Merged
feat(replay)!: Promote _experiments.autoFlushOnFeedback
option as default
#17220
andreiborza
merged 3 commits into
develop
from
billy/feat-replay-remove-experiment-auto-flush-feedback
Jul 31, 2025
+9
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature works pretty well so we are going to make this the default behavior and deprecate the settings. We should remove this in v10.
_experiments.autoFlushOnFeedback
_experiments.autoFlushOnFeedback
option
_experiments.autoFlushOnFeedback
option_experiments.autoFlushOnFeedback
option as default
size-limit report 📦
|
chargome
approved these changes
Jul 30, 2025
We need to add a |
AbhiPrasad
pushed a commit
that referenced
this pull request
Jul 31, 2025
Flushing on feedback widget opening is better than on submit as you get more relevant replay context, so we are going to make this the default behavior and deprecate the configuration option. The option will be removed in [v10](#17220).
andreiborza
approved these changes
Jul 31, 2025
_experiments.autoFlushOnFeedback
option as default_experiments.autoFlushOnFeedback
option as default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flushing on feedback widget opening is better than on submit as you get more relevant replay context, so we are going to make this the default behavior and remove the configuration option. This is deprecated in #17219