Skip to content

feat(replay)!: Promote _experiments.autoFlushOnFeedback option as default #17220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jul 29, 2025

Flushing on feedback widget opening is better than on submit as you get more relevant replay context, so we are going to make this the default behavior and remove the configuration option. This is deprecated in #17219

billyvg added 2 commits July 29, 2025 18:25
This feature works pretty well so we are going to make this the default behavior and deprecate the settings. We should remove this in v10.
@billyvg billyvg changed the title feat(replay/v9): Deprecate _experiments.autoFlushOnFeedback feat(replay): Remove _experiments.autoFlushOnFeedback option Jul 29, 2025
@billyvg billyvg changed the title feat(replay): Remove _experiments.autoFlushOnFeedback option feat(replay): Promote _experiments.autoFlushOnFeedback option as default Jul 29, 2025
@billyvg billyvg marked this pull request as ready for review July 29, 2025 22:30
@billyvg billyvg requested a review from a team as a code owner July 29, 2025 22:30
Copy link
Contributor

github-actions bot commented Jul 29, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.77 kB - -
@sentry/browser - with treeshaking flags 22.35 kB - -
@sentry/browser (incl. Tracing) 39.41 kB - -
@sentry/browser (incl. Tracing, Replay) 77.5 kB -0.05% -36 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.36 kB -0.06% -38 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 82.2 kB -0.05% -40 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 94.33 kB -0.05% -40 B 🔽
@sentry/browser (incl. Feedback) 40.45 kB - -
@sentry/browser (incl. sendFeedback) 28.45 kB - -
@sentry/browser (incl. FeedbackAsync) 33.34 kB - -
@sentry/react 25.5 kB - -
@sentry/react (incl. Tracing) 41.38 kB - -
@sentry/vue 28.2 kB - -
@sentry/vue (incl. Tracing) 41.22 kB - -
@sentry/svelte 23.79 kB - -
CDN Bundle 25.28 kB - -
CDN Bundle (incl. Tracing) 39.29 kB - -
CDN Bundle (incl. Tracing, Replay) 75.37 kB -0.05% -35 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 80.8 kB -0.05% -35 B 🔽
CDN Bundle - uncompressed 73.86 kB - -
CDN Bundle (incl. Tracing) - uncompressed 116.3 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 230.51 kB -0.05% -93 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.33 kB -0.04% -93 B 🔽
@sentry/nextjs (client) 43.44 kB - -
@sentry/sveltekit (client) 39.84 kB - -
@sentry/node-core 47.53 kB - -
@sentry/node 146.19 kB - -
@sentry/node - without tracing 91.63 kB - -
@sentry/aws-serverless 103.08 kB - -

View base workflow run

@AbhiPrasad
Copy link
Member

We need to add a MIGRATION.md entry for this, also cc @andreiborza because this is a breaking change

AbhiPrasad pushed a commit that referenced this pull request Jul 31, 2025
Flushing on feedback widget opening is better than on submit as you get
more relevant replay context, so we are going to make this the default
behavior and deprecate the configuration option. The option will be
removed in
[v10](#17220).
@andreiborza andreiborza merged commit eda7e33 into develop Jul 31, 2025
355 of 357 checks passed
@andreiborza andreiborza deleted the billy/feat-replay-remove-experiment-auto-flush-feedback branch July 31, 2025 14:06
@andreiborza andreiborza changed the title feat(replay): Promote _experiments.autoFlushOnFeedback option as default feat(replay)!: Promote _experiments.autoFlushOnFeedback option as default Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants