feat(aci): Update API to allow filter monitors by assignee #95501
Conversation
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #95501 +/- ##
===========================================
+ Coverage 36.17% 76.38% +40.21%
===========================================
Files 9960 10604 +644
Lines 557832 612180 +54348
Branches 23990 23990
===========================================
+ Hits 201783 467601 +265818
+ Misses 355640 142647 -212993
- Partials 409 1932 +1523 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| const query = typeof location.query.query === 'string' ? location.query.query : ''; | ||
|
|
||
| const filterKeys: TagCollection = Object.fromEntries( | ||
| Object.keys(DETECTOR_FILTER_KEYS).map(key => { |
There was a problem hiding this comment.
nit: IMO we should convert the constant DETECTOR_FILTER_KEYS into a hook useDetectorFilterKeys() so that we can use the useAssignedSearchValues() hook inside of it. That way all the logic stays together
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| elif actor is None: | ||
| assignee_query |= Q(owner_team_id__isnull=True, owner_user_id__isnull=True) | ||
| else: | ||
| # Unknown actor type, return a query that matches nothing |
There was a problem hiding this comment.
I think we want to raise here or otherwise report an error if there are types coming back from convert_actor_or_none_value that we don't support.
I think officially the right thing is assert_never.
| status_code=400, | ||
| ) | ||
| assert "owner" in response.data | ||
| def setUp(self): |
There was a problem hiding this comment.
Is it possible for us to have a test that actually filters by assignee?
leedongwei
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| ) | ||
| assignee_q = convert_assignee_values(values, projects, request.user) | ||
|
|
||
| if filter.operator == "!=": |
There was a problem hiding this comment.
super nit: is '!=' defined as a literal anywhere? just a little nervous about 'magic' strings.
There was a problem hiding this comment.
Unfortunately not. It's a repeated pattern in the codebase seen in other parts of the product too.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
leedongwei
removed
the
Scope: Frontend
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Allows filtering with assignee:
/api/0/organizations/sentry/detectors/?query=assignee%3A{me|my_teams|none|team_slug|user_email}&...