-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed as not planned
Labels
component: dashboardmeta: staleThis issue/PR is stale and will be closed soonThis issue/PR is stale and will be closed soon
Description
I'd like to use this issue for tracking some improvements to add to the new signup flow
This is following #16501 and #16543. It is a part of #15857.
- 1. A first/last name can be just whitespaces. We can use
.trim()
to check they are not in fact empty- @gtsiolis: +1, we do also validate such case sin other fields like environment variables, etc.
- 2. Last names should be optional New User Onboarding Flow UI #16501 (comment)
- @gtsiolis: This could be no longer relevant if we merged these two fields into one, see design export from New User Onboarding Flow UI #16501 (review).
- 3. Steps should be skippable New User Onboarding Flow UI #16501 (comment)
- @gtsiolis: Debatable as we some steps are required all steps but the last one should be easy to dismiss by just clicking continue.
- 4. We should add a stepper component so that the user knows ~ how long this process will take New User Onboarding Flow UI #16501 (comment)
-
5. The flow does not actually update commiter info New User Onboarding Flow UI #16501 (review)- @gtsiolis: No longer relevant as the page copy has been updated.
- 6. Completion of the flow is missing confetti Add confetti after new onboarding flow #16543
- @gtsiolis: Change has been merged, but haven't seen it in action—
may have to revert, see relevant discussion (internal).
- @gtsiolis: Change has been merged, but haven't seen it in action—
- 7. One cannot go back a step to correct info (a Back button)
- @gtsiolis: Debatable as all options can be changed later, expect the last step.
- 8. The phrasing on the
I'm signing up for Gitpod to...
question is a bit odd (reads weird with the options below it)- @gtsiolis: +1, an alternative phrase could be something like the design export from New User Onboarding Flow UI #16501 (review).
- 9. URL is spelled as
url
in the error message - 10. (low-prio): URLs such as
192.168.0.1/
,iphone.local
get past verification - 11. @phimae: Email should be Work Email
- @gtsiolis: Opened Update onboarding email input label #16558 to resolve this.
gtsiolis and mustard-mh
Metadata
Metadata
Assignees
Labels
component: dashboardmeta: staleThis issue/PR is stale and will be closed soonThis issue/PR is stale and will be closed soon