Skip to content

Update onboarding email input label #16558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Feb 24, 2023

Description

See relevant discussion (internal). @MichaelAring @phimae

How to test

Sign up and see how the email input is rendering on the first onboarding step.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis marked this pull request as ready for review February 24, 2023 11:27
@gtsiolis gtsiolis requested a review from a team February 24, 2023 11:27
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 24, 2023
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 24, 2023

I'm assuming there are no more changes needed to keep tracking this correctly. Looping in @selfcontained to confirm.

@gtsiolis gtsiolis mentioned this pull request Feb 24, 2023
11 tasks
@roboquat roboquat merged commit 190f9d2 into main Feb 27, 2023
@roboquat roboquat deleted the gt/update-onboarding-email-input-label branch February 27, 2023 06:31
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants