Skip to content

Backport of db: consider possibility of NextVaultRotation being unset on queue population (VAULT-35639) into release/1.19.x #30430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #30320 to be assessed for backporting due to the inclusion of the label backport/1.19.x.

The below text is copied from the body of the original PR.


Description

NextVaultRotation was introduced to the static role struct in Vault 1.15.0. In 1.19.0, vault changed to use this field to determine when to enqueue roles for rotation here. However, if a static role was originally created on a version older than 1.15.0, it won’t have a NextVaultRotation value set. After upgrading to 1.19.0 or above, vault sees this value as the zero value (time.Time{}) and rotates the cred immediately.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 28, 2025
@elliesterner elliesterner added this to the 1.19.3 milestone Apr 28, 2025
Copy link

github-actions bot commented Apr 28, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@elliesterner elliesterner merged commit fb71a62 into release/1.19.x Apr 28, 2025
84 of 85 checks passed
@elliesterner elliesterner deleted the backport/elliesterner/check-for-zero-nvr-on-queue-population/firstly-lasting-mako branch April 28, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants