Discard string context when using antiquoted string as attrset key #1910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This manifested in practice because I was trying to do something like
this:
which gave me errors about not being allowed to have string context. We
do actually need the string context (otherwise we end up not depending
on the repository, and the sandbox prevents us from looking at it!), so
we have to be careful about where to discard. The simplest thing is to
discard where it's needed: as we create the attrset key.