Better support for file: urls in repositories #1915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a repository whose URL is a `file:` URL, then you will end up with package sources being specified by `fetchurl` calls with `file:` URLs. Now, in principle `curl` can fetch from `file:` URLs, but the Nix sandbox isn't relaxed in the right way to allow it to see the file (just the internet!). We can get around this by using `builtins.path` instead.
andreabedini
approved these changes
Apr 12, 2023
|
I was just chatting with @michaelpj and there is some concern this might cause some non reproducibility. If the |
|
I think I've mildly convinced myself it's okay. It won't bust the resulting derivation, since it will create a "proper" FOD immediately. Conceivably I think it could go wrong if there was a GC right in between evaluation and starting to build the derivations, perhaps 🤔 |
andreabedini
added a commit
to IntersectMBO/cardano-haskell-packages
that referenced
this pull request
Apr 14, 2023
After #200 we started seeing CI failures including messages like "source not available" or "don't know how to build these paths". AFAIU these could be consequence of the changes in input-output-hk/haskell.nix#1915 and/or input-output-hk/haskell.nix#1910. To try to unblock this I am a adding the `--fallback` option to nix [1] which allows nix to build a derivation that fails the substitution. 🤞 [1] https://nixos.org/manual/nix/stable/command-ref/opt-common.html#opt-fallback
lehins
pushed a commit
to IntersectMBO/cardano-haskell-packages
that referenced
this pull request
Apr 14, 2023
* Release consensus 0.4 * Try to work around nix failures with --fallback After #200 we started seeing CI failures including messages like "source not available" or "don't know how to build these paths". AFAIU these could be consequence of the changes in input-output-hk/haskell.nix#1915 and/or input-output-hk/haskell.nix#1910. To try to unblock this I am a adding the `--fallback` option to nix [1] which allows nix to build a derivation that fails the substitution. 🤞 [1] https://nixos.org/manual/nix/stable/command-ref/opt-common.html#opt-fallback * Revert "Rework builder to work with new haskell.nix (#200)" This reverts commit 408c4f4. --------- Co-authored-by: Andrea Bedini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a repository whose URL is a
file:URL, then you will endup with package sources being specified by
fetchurlcalls withfile:URLs. Now, in principle
curlcan fetch fromfile:URLs, but the Nixsandbox isn't relaxed in the right way to allow it to see the file (just
the internet!). We can get around this by using
builtins.pathinstead.