This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][HIP] Update HIP AMD XFAILs #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_backend test was missing the HIP plugin case. The ESIMD tests are not supported for HIP in general, not just on Nvidia. The subgroup built-ins were added for AMD in intel/llvm#4208. The kernel_info.cpp test was fixed in intel#474 and now passes with HIP. The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia, not on AMD.
npmiller
requested review from
AlexeySachkov,
bader,
kbobrovs,
Pennycook,
romanovvlad,
v-klochkov,
vladimirlaz and
a team
as code owners
v-klochkov
approved these changes
Nov 10, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
The get_backend test was missing the HIP plugin case. The ESIMD tests are not supported for HIP in general, not just on Nvidia. The subgroup built-ins were added for AMD in intel#4208. The kernel_info.cpp test was fixed in intel#474 and now passes with HIP. The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia, not on AMD.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_backend test was missing the HIP plugin case.
The ESIMD tests are not supported for HIP in general, not just on
Nvidia.
The subgroup built-ins were added for AMD in intel/llvm#4208.
The kernel_info.cpp test was fixed in #474 and now passes with HIP.
The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia,
not on AMD.