Skip to content

[SYCL][LIBCLC] Add subgroup builtins for AMDGCN #4208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2021

Conversation

jchlanda
Copy link
Contributor

This patch brings in support for the following builtins:

  • __spirv_SubgroupMaxSize
  • __spirv_NumSubgroups
  • __spirv_SubgroupId
  • __spirv_SubgroupSize

The implementation follows that of HIP.

@jchlanda jchlanda requested a review from bader as a code owner July 28, 2021 14:27
@jchlanda
Copy link
Contributor Author

@bader is there anything else you'd like me to do for this PR?

@bader
Copy link
Contributor

bader commented Jul 30, 2021

@bader is there anything else you'd like me to do for this PR?

Just re-request the review via GitHub API to let me know that review is expected. :)

@jchlanda
Copy link
Contributor Author

request

@bader is there anything else you'd like me to do for this PR?

Just re-request the review via GitHub API to let me know that review is expected. :)

Cool, will do that in future. Thank you.

@bader bader added the libclc libclc project related issues label Jul 30, 2021
@bader bader merged commit dfa4f02 into intel:sycl Jul 30, 2021
@jchlanda jchlanda deleted the subgroup_builtins branch July 30, 2021 17:55
zahiraam pushed a commit to zahiraam/llvm-1 that referenced this pull request Aug 2, 2021
This patch brings in support for the following builtins: 
* `__spirv_SubgroupMaxSize`
* `__spirv_NumSubgroups`
* `__spirv_SubgroupId`
*  `__spirv_SubgroupSize`

The implementation follows that of HIP.
npmiller added a commit to npmiller/llvm-test-suite that referenced this pull request Nov 10, 2021
The get_backend test was missing the HIP plugin case.

The ESIMD tests are not supported for HIP in general, not just on
Nvidia.

The subgroup built-ins were added for AMD in intel/llvm#4208.

The kernel_info.cpp test was fixed in intel#474 and now passes with HIP.

The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia,
not on AMD.
vladimirlaz pushed a commit to intel/llvm-test-suite that referenced this pull request Nov 11, 2021
The get_backend test was missing the HIP plugin case.

The ESIMD tests are not supported for HIP in general, not just on
Nvidia.

The subgroup built-ins were added for AMD in intel/llvm#4208.

The kernel_info.cpp test was fixed in #474 and now passes with HIP.

The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia,
not on AMD.
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
The get_backend test was missing the HIP plugin case.

The ESIMD tests are not supported for HIP in general, not just on
Nvidia.

The subgroup built-ins were added for AMD in intel#4208.

The kernel_info.cpp test was fixed in intel#474 and now passes with HIP.

The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia,
not on AMD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libclc libclc project related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants