[SYCL][LIBCLC] Add subgroup builtins for AMDGCN #4208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Jul 28, 2021
Co-authored-by: Alexey Bader <[email protected]>
Co-authored-by: Alexey Bader <[email protected]>
|
@bader is there anything else you'd like me to do for this PR? |
bader
approved these changes
Jul 30, 2021
Just re-request the review via GitHub API to let me know that review is expected. :) |
Cool, will do that in future. Thank you. |
zahiraam
pushed a commit
to zahiraam/llvm-1
that referenced
this pull request
Aug 2, 2021
This patch brings in support for the following builtins: * `__spirv_SubgroupMaxSize` * `__spirv_NumSubgroups` * `__spirv_SubgroupId` * `__spirv_SubgroupSize` The implementation follows that of HIP.
npmiller
added a commit
to npmiller/llvm-test-suite
that referenced
this pull request
Nov 10, 2021
The get_backend test was missing the HIP plugin case. The ESIMD tests are not supported for HIP in general, not just on Nvidia. The subgroup built-ins were added for AMD in intel/llvm#4208. The kernel_info.cpp test was fixed in intel#474 and now passes with HIP. The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia, not on AMD.
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Nov 11, 2021
The get_backend test was missing the HIP plugin case. The ESIMD tests are not supported for HIP in general, not just on Nvidia. The subgroup built-ins were added for AMD in intel/llvm#4208. The kernel_info.cpp test was fixed in #474 and now passes with HIP. The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia, not on AMD.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
The get_backend test was missing the HIP plugin case. The ESIMD tests are not supported for HIP in general, not just on Nvidia. The subgroup built-ins were added for AMD in intel#4208. The kernel_info.cpp test was fixed in intel#474 and now passes with HIP. The kernel_bundle_ignore_sycl_external.cpp only fails with HIP Nvidia, not on AMD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings in support for the following builtins:
__spirv_SubgroupMaxSize__spirv_NumSubgroups__spirv_SubgroupId__spirv_SubgroupSizeThe implementation follows that of HIP.