[SYCL] Fix Win path handling in lit config #18135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
requested review from
aelovikov-intel and
sarnex
and removed request for
aelovikov-intel
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Apr 22, 2025
sarnex
pushed a commit
that referenced
this pull request
Apr 28, 2025
The quote_path bug does not only affecting Windows(#18135) but also Linux. This patch address this problem. This bug affects all usage of `quote_path`, notably the `level_zero_dev_kit` feature. ``` zsh$> cat 1.py import shlex ret = shlex.quote('') if ret: print("bug!") else: print("not a problem") zsh$> python3 1.py bug! ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes consequence of 4150bdf
f'"{path}"' converts empty string to the string with quotes and length == 2 that breaks checks for not empty path. Fixes that.