[SYCL][ESIMD] Remove unused APIs from simd_view class #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kychendev
approved these changes
Aug 24, 2020
vladimirlaz
approved these changes
Aug 25, 2020
bader
changed the title
bader
reviewed
Aug 25, 2020
| @@ -48,8 +48,8 @@ bool test_simd_select() __attribute__((sycl_device)) { | |||
| bool test_2d_offset() __attribute__((sycl_device)) { | |||
| simd<int, 16> v = 0; | |||
| auto ref = v.format<short, 8, 4>(); | |||
| return ref.select<2, 2, 2, 2>(2, 1).getOffset<0>() == 1 && | |||
| ref.select<2, 2, 2, 2>(2, 1).getOffset<1>() == 2; | |||
| return ref.select<2, 2, 2, 2>(2, 1).getOffsetX() == 1 && | |||
There was a problem hiding this comment.
It looks like removed API is public, so I don't think that [NFC] tag can be applied to this change.
bader
changed the title
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Add query to retrieve adapter handle from platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.