Skip to content

[SYCL][ESIMD] Remove unused APIs from simd_view class #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2020
Merged

[SYCL][ESIMD] Remove unused APIs from simd_view class #2365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions sycl/include/CL/sycl/INTEL/esimd/esimd_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,21 +89,6 @@ template <typename BaseTy, typename RegionTy> class simd_view {
return getTopRegion(M_region).M_offset_y;
}

template <int Dim = 0> static constexpr int getSize() {
static_assert(Dim <= is2D(), "region is not two-dimensional");
return (Dim == 0) ? getSizeX() : getSizeY();
}

template <int Dim = 0> static constexpr int getStride() {
static_assert(Dim <= is2D(), "region is not two-dimensional");
return (Dim == 0) ? getStrideX() : getStrideY();
}

template <int Dim = 0> constexpr uint16_t getOffset() const {
static_assert(Dim <= is2D(), "region is not two-dimensional");
return (Dim == 0) ? getOffsetX() : getOffsetX();
}

// Read this simd_view object.
value_type read() const {
using BT = typename BaseTy::element_type;
Expand Down
4 changes: 2 additions & 2 deletions sycl/test/basic_tests/esimd/simd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ bool test_simd_select() __attribute__((sycl_device)) {
bool test_2d_offset() __attribute__((sycl_device)) {
simd<int, 16> v = 0;
auto ref = v.format<short, 8, 4>();
return ref.select<2, 2, 2, 2>(2, 1).getOffset<0>() == 1 &&
ref.select<2, 2, 2, 2>(2, 1).getOffset<1>() == 2;
return ref.select<2, 2, 2, 2>(2, 1).getOffsetX() == 1 &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like removed API is public, so I don't think that [NFC] tag can be applied to this change.

ref.select<2, 2, 2, 2>(2, 1).getOffsetY() == 2;
}

bool test_simd_bin_op_promotion() __attribute__((sycl_device)) {
Expand Down