-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL] Disable fallback assert by default #4694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Regressions fixed in intel/llvm-test-suite#498 |
@s-kanaev, please, fill the description. I miss the context - why do we need this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ping. |
Done |
sycl/include/CL/sycl/queue.hpp
Outdated
#if defined(SYCL_ENABLE_FALLBACK_ASSERT) && !defined(__NVPTX__) | ||
#define __SYCL_USE_FALLBACK_ASSERT 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#if defined(SYCL_ENABLE_FALLBACK_ASSERT) && !defined(__NVPTX__) | |
#define __SYCL_USE_FALLBACK_ASSERT 1 | |
#if defined(SYCL_ENABLE_FALLBACK_ASSERT) | |
#if defined(__NVPTX__) | |
#warning "Fallback assert is not supported on NVPTX target" | |
#define __SYCL_USE_FALLBACK_ASSERT 0 | |
#else | |
#define __SYCL_USE_FALLBACK_ASSERT 1 | |
#endif |
Defining this macro enables the fallback assert feature even on devices without native support.
I suggest we add a note to the documentation that fallback assert is not supported on CUDA back-end.
BTW, is it supported on HIP?
Signed-off-by: Sergey Kanaev <[email protected]>
…ing of fallback assert Signed-off-by: Sergey Kanaev <[email protected]>
/verify with intel/llvm-test-suite#754 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the documentation needs some tweaks.
Co-authored-by: Greg Lueck <[email protected]>
/verify with intel/llvm-test-suite#754 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@s-kanaev, please, fix pre-commit fails.
/verify with intel/llvm-test-suite#754 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, fix failures in pre-commit.
Failed Tests (9):
SYCL :: Assert/assert_in_kernels.cpp
SYCL :: Assert/assert_in_multiple_tus.cpp
SYCL :: Assert/assert_in_multiple_tus_one_ndebug.cpp
SYCL :: Assert/assert_in_one_kernel.cpp
SYCL :: Assert/assert_in_simultaneous_kernels.cpp
SYCL :: Assert/assert_in_simultaneously_multiple_tus.cpp
SYCL :: Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp
SYCL :: DeviceLib/assert-aot.cpp
SYCL :: DeviceLib/assert.cpp
These are resolved in intel/llvm-test-suite#754 |
Signed-off-by: Sergey Kanaev <[email protected]>
Due excessive amount of issues submitted against fallback assert implementation the fallback assert is now disabled by default until fixed.