[SYCL] Improve code-ownership rules for ESIMD/Tools #5287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Gindinson <[email protected]>
bader
reviewed
Jan 12, 2022
Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
changed the title
AlexeySachkov
previously approved these changes
Jan 12, 2022
Signed-off-by: Artem Gindinson <[email protected]>
AlexeySachkov
previously approved these changes
Jan 12, 2022
bader
reviewed
Jan 12, 2022
Co-authored-by: Alexey Bader <[email protected]>
AlexeySachkov
approved these changes
Jan 12, 2022
@elizabethandrews, I think it corresponds to the SYCL library-embedded directories like |
elizabethandrews
approved these changes
Jan 12, 2022
premanandrao
approved these changes
Jan 12, 2022
|
@intel/dpcpp-esimd-reviewers, ping. |
kbobrovs
reviewed
Jan 12, 2022
kbobrovs
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch aims to enforce ESIMD-specific code-ownership on the newly created
dedicated directories. This allows for seamless DPC++ Tools code-ownership of
non-ESIMD
llvm/-contained files.Signed-off-by: Artem Gindinson [email protected]