Add delete all breakpoints feature to debugger (javascript) #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: Levente Orban [email protected]
robertsipka
reviewed
Feb 28, 2017
| appendLog("No active breakpoints.") | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this form would be better, whats your opinion?
activeBreakpoints.length != 0 ? activeBreakpoints.splice(0) : appendLog("No active breakpoints.")
There was a problem hiding this comment.
You can't use splice() function in the activeBreakpoints object.
There was a problem hiding this comment.
It's my bad, I thought that activeBreakpoints is an array.
zherczeg
reviewed
Feb 28, 2017
| if (!found) | ||
| { | ||
| appendLog("No active breakpoints.") | ||
| } |
There was a problem hiding this comment.
Isn't there an easier way to check whether activeBreakpoints is empty?
There was a problem hiding this comment.
You can check with Object.keys(acviteBreakpoints).length
There was a problem hiding this comment.
That is more complicated. Keep the bool then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can able to use
delete allcommand, to clear the breakpoints from the whole project.JerryScript-DCO-1.0-Signed-off-by: Levente Orban [email protected]