Skip to content

Add delete all breakpoints feature to debugger (javascript) #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Add delete all breakpoints feature to debugger (javascript) #1628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion jerry-debugger/jerry-client-ws.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,23 @@ <h2>JerryScript HTML (WebSocket) Debugger Client</h2>
{
breakpoint = activeBreakpoints[index];

if (!breakpoint)
if (index == "all")
{
var found = false;

for (var i in activeBreakpoints)
{
delete activeBreakpoints[i];
found = true;
}

if (!found)
{
appendLog("No active breakpoints.")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there an easier way to check whether activeBreakpoints is empty?

Copy link
Contributor

@robertsipka robertsipka Feb 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check with Object.keys(acviteBreakpoints).length

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is more complicated. Keep the bool then.

}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this form would be better, whats your opinion?
activeBreakpoints.length != 0 ? activeBreakpoints.splice(0) : appendLog("No active breakpoints.")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't use splice() function in the activeBreakpoints object.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my bad, I thought that activeBreakpoints is an array.

else if (!breakpoint)
{
appendLog("No breakpoint found with index " + index);
return;
Expand Down