Add tests for the es5.1 profile to tools/run-tests.py #2217
Conversation
tools/run-tests.py
Outdated
| @@ -261,6 +279,9 @@ def run_jerry_tests(options): | |||
| if '--profile=es2015-subset' not in job.build_args: | |||
| skip_list.append(r"es2015\/") | |||
|
|
|||
| if '--profile=es5.1' not in job.build_args: | |||
There was a problem hiding this comment.
There is no skip list for es5.1, so we don't need this part.
|
@pmarkee please rebase your PR. |
|
@LaszloLango done |
|
@LaszloLango @pmarkee I've created the #2228 PR to try and resolve the too big travis output problem. |
|
@pmarkee could you please rebase the PR? The test runner quiet mode has landed which should fix the Travis output problem(s). |
tools/run-tests.py
Outdated
| '--snapshot-save=on', '--snapshot-exec=on', '--vm-exec-stop=on', '--profile=es2015-subset']) | ||
| '--snapshot-save=on', '--snapshot-exec=on', '--vm-exec-stop=on', '--profile=es2015-subset']), | ||
| Options('unittests', | ||
| ['--unittests', '--jerry-cmdline=off', '--error-messages=on', '--snapshot-save=on', '--snapshot-exec=on', '--vm-exec-stop=on', '--profile=es2015-subset', '--mem-stats=on']), |
There was a problem hiding this comment.
It seems that these lines are too long (some of them are above 120 characters). We should extract the common options to a different variable and just concatenate the rest where needed.
There was a problem hiding this comment.
Thanks for the review! Maybe we should do this to other parts of the code as well, it would make the lines much shorter and easier to read. For now I think we should just break the lines that are too long, and apply your suggestion in a separate PR afterwards.
JerryScript-DCO-1.0-Signed-off-by: Peter Marki [email protected]
|
LGTM |
JerryScript-DCO-1.0-Signed-off-by: Peter Marki [email protected]