Skip to content

Remove duplications from test runner #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2018

Conversation

akosthekiss
Copy link
Member

  • Code contains syntactic duplications (e.g., build options copy-
    pasted repeatedly).
  • Build options for test suites contain semantic duplications
    (ES5.1 profile builds happen multiple times, once by not
    specifying a profile and once by specifying es5.1 profile
    explicitly).
  • External build options are not taken into account when detecting
    duplicated builds.

This patch provides improvement for these issues.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]

- Code contains syntactic duplications (e.g., build options copy-
  pasted repeatedly).
- Build options for test suites contain semantic duplications
  (ES5.1 profile builds happen multiple times, once by not
  specifying a profile and once by specifying es5.1 profile
  explicitly).
- External build options are not taken into account when detecting
  duplicated builds.

This patch provides improvement for these issues.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
@akosthekiss akosthekiss added tools Related to the tooling scripts test Related to testing labels May 29, 2018
@akosthekiss
Copy link
Member Author

Effect on Tracis CI:

job on master on PR
"Linux/x86-64 Build & Correctness Tests" 5:39 4:29
"Linux/x86 (cpointer-32bit) Build & Correctness Tests" 6:57 5:36
"Linux/ARM Build & Correctness Tests" 16:56 14:55
"OSX/x86-64 Build, Correctness & Unit Tests" 13:35 10:18
"ASAN Tests" 17:21 10:56
"UBSAN Tests" 10:07 6:18

(Execution times to be taken with a grin of salt as they can exhibit even +-2 mins of deviation.)

Example effect on executed test jobs: for UBSAN, the following equivalent test jobs are not executed multiple times superfluously:

  • jerry_tests-es5.1-debug == jerry_tests-es5.1
  • jerry_tests-es5.1-debug-snapshot == jerry_tests-es5.1-snapshot
  • jerry_tests-es5.1-debug-cpointer_32bit == jerry_tests-es5.1 (!!!)
  • jerry_test_suite-minimal-debug == jerry_test_suite-minimal
  • jerry_test_suite-minimal-debug-snapshot == jerry_test_suite-minimal-snapshot
  • jerry_test_suite-es2015_subset == jerry_tests-es2015_subset-debug
  • jerry_test_suite-es2015_subset-debug-snapshot == jerry_test_suite-es2015_subset-snapshot

(The why: UBSAN has --debug as an external compile flag that makes debug and "non-debug" test jobs equivalent. It also has -m32 and --system-allocator=on, which makes the --cpointer-32bit=on --mem-heap=1024 flags of the jerry_tests-es5.1-debug-cpointer_32bit test job irrelevant.)

Note: This PR partially reverts #2217.

@LaszloLango
Copy link
Contributor

AFAIK, the sanitizers only works with the system allocator. There is no make sense to run them with jerry allocator.

@akosthekiss
Copy link
Member Author

@LaszloLango No question. But run-tests.py has a fixed set of test jobs to run (each has its own set of build options) and CI jobs can only append extra build arguments to them (the same set of extras to every test job). There is no way (at least now) to select which test jobs to run individually, e.g., from the list of JERRY_TESTS_OPTIONS. If --jerry-tests is given on the command line, all 7 jobs listed therein will be executed.

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi
Copy link
Contributor

yichoi commented May 30, 2018

LGTM

@yichoi yichoi merged commit 2291467 into jerryscript-project:master May 30, 2018
@akosthekiss akosthekiss deleted the run-tests-duplicates branch May 31, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to testing tools Related to the tooling scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants