Simplify source evaluation options. #2431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
rerobika
force-pushed
the
parser_strict_flags
branch
from
ce8ac5d to
58b2512
Compare
zherczeg
requested changes
Jul 19, 2018
| @@ -969,12 +969,12 @@ Perform JavaScript `eval`. | |||
| jerry_value_t | |||
| jerry_eval (const jerry_char_t *source_p, | |||
| size_t source_size, | |||
| bool is_strict); | |||
| uint32_t parse_opts); | |||
There was a problem hiding this comment.
If this is an api change please add it to #2213.
| bool is_strict_call = (is_direct && is_called_from_strict_mode_code); | ||
| uint32_t is_strict_call = ECMA_PARSE_STRICT_MODE | ECMA_PARSE_DIRECT_EVAL; | ||
|
|
||
| if ((parse_opts & is_strict_call) != is_strict_call) |
There was a problem hiding this comment.
I think it's an equivalent conversion. In the previous version the is_strict_call variable was only true, if both options were true. So it means whether one of the ECMA_PARSE_STRICT_MODE or ECMA_PARSE_DIRECT_EVAL flags are not enabled, the script must be executed in non-strict mode.
Closed
zherczeg
approved these changes
Jul 20, 2018
| bool is_strict_call = (is_direct && is_called_from_strict_mode_code); | ||
| uint32_t is_strict_call = ECMA_PARSE_STRICT_MODE | ECMA_PARSE_DIRECT_EVAL; | ||
|
|
||
| if ((parse_opts & is_strict_call) != is_strict_call) |
Merged
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 29, 2018
Picked from upstream jerryscript-project/jerryscript#2431
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 29, 2018
Picked from upstream jerryscript-project/jerryscript#2431
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 29, 2018
Picked from upstream jerryscript-project/jerryscript#2431
yorkie
pushed a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 30, 2018
Refs: jerryscript-project/jerryscript#2431 Refs: jerryscript-project/jerryscript#2496 Refs: jerryscript-project/jerryscript#2485 Refs: jerryscript-project/jerryscript#2530 Refs: jerryscript-project/jerryscript#2547 Refs: jerryscript-project/jerryscript#2436 Refs: jerryscript-project/jerryscript#2467 Refs: jerryscript-project/jerryscript#2481 Refs: jerryscript-project/jerryscript#2408 Refs: jerryscript-project/jerryscript#2430 Refs: jerryscript-project/jerryscript#2439 Refs: jerryscript-project/jerryscript#2588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]