Skip to content

Introducing internal properties. #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

zherczeg
Copy link
Member

Native handle and pointer are moved to internal properties.

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosthekiss akosthekiss added the ecma core Related to core ECMA functionality label Aug 28, 2018
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka
Copy link
Contributor

@zherczeg : Please rebase it to master.

Native handle and pointer are moved to internal properties.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
@robertsipka robertsipka merged commit 0a40f55 into jerryscript-project:master Sep 4, 2018
@zherczeg zherczeg deleted the internal_property branch September 4, 2018 13:54
legendecas added a commit to yodaos-project/ShadowNode that referenced this pull request Nov 29, 2018
legendecas added a commit to yodaos-project/ShadowNode that referenced this pull request Nov 29, 2018
legendecas added a commit to yodaos-project/ShadowNode that referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecma core Related to core ECMA functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants