-
Notifications
You must be signed in to change notification settings - Fork 77
ENH: Add install-tags filtering for wheel generation (updated) #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # mesonpy/__init__.py
updates: - [github.com/charliermarsh/ruff-pre-commit: v0.0.236 → v0.0.238](astral-sh/ruff-pre-commit@v0.0.236...v0.0.238)
This reverts commit 37f905c.
Hi @peter-urban, thank you! This is just missing a test, and applying the changes from pre-commit. Could you either tick the "allow maintainers to make changes" box in this PR, so that I can push that, or apply the pre-commit changes yourself and add the test below to def test_install_tags(package_purelib_and_platlib, tmp_path_session):
project = mesonpy.Project(
package_purelib_and_platlib,
tmp_path_session,
meson_args={
'install': ['--tags', 'purelib'],
}
)
assert project.is_pure |
@FFY00 thanks :-) I merged with main again and added the test you suggested (I assume you meant test_project.py) Looking forward to get this merged! |
Yeah 😅 Thanks! I think it's just missing the pre-commit changes. You can run |
thanks, first time I work with pre-commit :-) |
No worries. Thank you for getting this through. The Debian CI failure is unrelated. Let's just wait to see if the rest of the CI is green, and then we can merge 🚀 |
Ugh, seems now we have conflicts. I am just gonna open a new PR and fix it myself, as I don't want to bother you. |
Closed in favor of #288. Thank you so much for the contribution @peter-urban! |
This is a PR for #68
It is a continuation of (and should probably replace) @Brishen's PR #267 which used my code, but has not been updated (since two weeks) to include the suggestions/changes made in reaction to @FFY00's comments.