Skip to content

ENH: Add install-tags filtering for wheel generation (updated) #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a7ad70c
add unofficial 'install-tags' option
peter-urban Nov 25, 2022
dc77812
Merge branch 'origin-main' into fork-main
peter-urban Nov 28, 2022
85e7092
Merge remote-tracking branch 'origin/main' into fork-main
peter-urban Dec 1, 2022
d2d9ee2
Merge remote-tracking branch 'origin/main' into fork-main
peter-urban Dec 2, 2022
1acfde3
Merge remote-tracking branch 'original/main'
Jan 17, 2023
794bf78
Update formatting in __init__.py
Jan 17, 2023
1158210
Pull Request #267: Add install-tags filtering for wheel generation
peter-urban Jan 17, 2023
94cea55
Add install-tags filtering for wheel generation
peter-urban Jan 17, 2023
c4362c6
Merge branch 'pulls/1900654986/267' into fork-main
peter-urban Jan 17, 2023
bd05d11
parse install args instead of using an extra install-tags field
peter-urban Jan 18, 2023
dbf0943
use argparse to parse the "install" args for "--tags"
peter-urban Jan 18, 2023
c36b880
Merge remote-tracking branch 'origin/main'
peter-urban Jan 20, 2023
ca7afeb
Merge remote-tracking branch 'origin/main'
peter-urban Jan 27, 2023
02a4548
Merge remote-tracking branch 'origin/main'
peter-urban Jan 30, 2023
37f905c
MAINT: bump repositories
pre-commit-ci[bot] Jan 31, 2023
fb00c60
Merge remote-tracking branch 'origin/pre-commit-ci-update-config'
peter-urban Jan 31, 2023
2f9d21f
Revert "MAINT: bump repositories"
peter-urban Jan 31, 2023
c50574e
added test suggested by FFY00
peter-urban Jan 31, 2023
12d8c5a
Merge remote-tracking branch 'origin/main'
peter-urban Jan 31, 2023
1ea1a53
apply pre-commit changes
peter-urban Jan 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion mesonpy/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

from __future__ import annotations

import argparse
import collections
import contextlib
import functools
Expand Down Expand Up @@ -921,7 +922,25 @@ def _info(self, name: str) -> Dict[str, Any]:
@property
def _install_plan(self) -> Dict[str, Dict[str, Dict[str, str]]]:
"""Meson install_plan metadata."""
return self._info('intro-install_plan').copy()

# copy the install plan so we can modify it
install_plan = self._info('intro-install_plan').copy()

# parse install args for install tags (--tags)
parser = argparse.ArgumentParser()
parser.add_argument('--tags')
args, _ = parser.parse_known_args(self._meson_args['install'])

# filter the install_plan for files that do not fit the install tags
if args.tags:
install_tags = args.tags.split(',')

for files in install_plan.values():
for file, details in list(files.items()):
if details['tag'].strip() not in install_tags:
del files[file]

return install_plan

@property
def _copy_files(self) -> Dict[str, str]:
Expand Down
11 changes: 11 additions & 0 deletions tests/test_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,14 @@ def last_two_meson_args():
def test_unknown_user_args(package, tmp_path_session):
with pytest.raises(mesonpy.ConfigError):
mesonpy.Project(package_dir / f'unknown-user-args-{package}', tmp_path_session)


def test_install_tags(package_purelib_and_platlib, tmp_path_session):
project = mesonpy.Project(
package_purelib_and_platlib,
tmp_path_session,
meson_args={
'install': ['--tags', 'purelib'],
}
)
assert project.is_pure