-
Notifications
You must be signed in to change notification settings - Fork 12.9k
not escape unicode char for import path string. #39463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Friendly ping ~ @rbuckton |
So, I chatted with Ryan about this and we think it's better to be doing this, so I'm gonna try run it against everything we've got - but we don't think there's going to be too many test cases which will get hit. Given our real-world test suites will all probably be using ascii everywhere. @typescript-bot test this |
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
OK, looked through all these results - nothing seems to stand out to me as being caused by the unescaped chars. At this point we can only be 100% certain when the RC drops (or folks using nightly hit something) but I'm reasonably confident. I'm going to merge, thanks @ShuiRuTian 👍 |
Fixes #39027