Skip to content

Renames in servermode per feedback #39883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Renames in servermode per feedback #39883

merged 3 commits into from
Aug 5, 2020

Conversation

sheetalkamat
Copy link
Member

Renames done as pert #39735 (review)

Not sure if its late to do this but here is the PR

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 3, 2020
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 3, 2020

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at d320625. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #39888 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 3, 2020
Component commits:
d320625 Server mode renames as per feedback
@DanielRosenwasser
Copy link
Member

@mjbvz should we change the TSServer flag as well? Or should we leave it alone and keep the rename as part of the API?

@amcasey
Copy link
Member

amcasey commented Aug 3, 2020

Obviously, I'm fine with the names I suggested, but I'm not stuck to them.

@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 5, 2020

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-4.0 on this PR at 508226e. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 5, 2020
Component commits:
d320625 Server mode renames as per feedback

e8d798d More renames

508226e Merge branch 'master' into serverModeRename
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.0 and LKG

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 5, 2020

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at 508226e. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 5, 2020
Component commits:
d320625 Server mode renames as per feedback

e8d798d More renames

508226e Merge branch 'master' into serverModeRename
@sheetalkamat
Copy link
Member Author

@amcasey @DanielRosenwasser Ready to merge ?

@sheetalkamat sheetalkamat merged commit da5ff57 into master Aug 5, 2020
@sheetalkamat sheetalkamat deleted the serverModeRename branch August 5, 2020 19:19
sheetalkamat added a commit that referenced this pull request Aug 5, 2020
#39888)

* Cherry-pick PR #39883 into release-4.0

Component commits:
d320625 Server mode renames as per feedback

e8d798d More renames

508226e Merge branch 'master' into serverModeRename

* Update LKG

Co-authored-by: Sheetal Nandi <[email protected]>
Co-authored-by: typescript-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants