Skip to content

🤖 Pick PR #39883 (Renames in servermode per feedback) into release-4.0 #39888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2020
Merged

🤖 Pick PR #39883 (Renames in servermode per feedback) into release-4.0 #39888

merged 2 commits into from
Aug 5, 2020

Conversation

typescript-bot
Copy link
Collaborator

This cherry-pick was triggered by a request on #39883
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.

cc @DanielRosenwasser

@typescript-bot typescript-bot mentioned this pull request Aug 3, 2020
Merged
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 3, 2020
@typescript-bot typescript-bot force-pushed the pick/39883/release-4.0 branch from 9891ee8 to e053a4c Compare August 5, 2020 19:06
sheetalkamat and others added 2 commits August 5, 2020 19:12
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#39883 into release-4.0
27c12ef 
Component commits:
d320625 Server mode renames as per feedback

e8d798d More renames

508226e Merge branch 'master' into serverModeRename
@typescript-bot
Update LKG
e751678
@typescript-bot typescript-bot force-pushed the pick/39883/release-4.0 branch from e053a4c to e751678 Compare August 5, 2020 19:13
@sheetalkamat
Copy link
Member

Waiting on tests to pass before merging

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Aug 5, 2020 •
edited
Loading

Hey, (@mjbvz @amcasey) I realized if we try to get this into the RC, nothing will work out of the box for people. We either need to give editors some sort of grace period and push back the RC by a day, or to ship the RC as-is and have editors adjust after the fact.

@DanielRosenwasser
Copy link
Member

Amended my last comment to clarify the options.

@sheetalkamat sheetalkamat merged commit 10bfb7c into microsoft:release-4.0 Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@typescript-bot @sheetalkamat @DanielRosenwasser