Skip to content

🤖 Pick PR #46630 (Allow import assertions on esm impo...) into release-4.5 #46648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

typescript-bot
Copy link
Collaborator

This cherry-pick was triggered by a request on #46630
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.

cc @andrewbranch

Component commits:
8ba5d7c Allow import assertions on esm imports under module: nodenext

2c5b9a9 Changes to copy

b48868d Merge branch 'main' into import-assertions-module-nodenext
@andrewbranch andrewbranch force-pushed the pick/46630/release-4.5 branch from 3148b69 to 035ac35 Compare November 3, 2021 17:03
@DanielRosenwasser
Copy link
Member

Why does this need to be cherry-picked into release-4.5? This mode isn't valid in TS 4.5.

@andrewbranch
Copy link
Member

🤦 good point, I'm still thinking about the experimental features as something you can enable with an extra switch... the nice thing about picking the nightly route is we can just merge fixes into main as they come and it'll always be getting a little less experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants