Skip to content

Update MSYS2 default installed package to it's recommendation. #6276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

wy-luke
Copy link

@wy-luke wy-luke commented May 5, 2023

In MSYS2 official doc, the default installed package became mingw-w64-ucrt-x86_64-gcc. It says that ucrt is a better solution.

UCRT (Universal C Runtime) is a newer version which is also used by Microsoft Visual Studio by default. It should work and behave as if the code was compiled with MSVC.

So I thought maybe it's better to change our doc according to this change.

I changed the mingw-w64-x86_64-toolchain to mingw-w64-ucrt-x86_64-toolchain and changed the path from C:\msys64\mingw64\bin to C:\msys64\ucrt64\bin and so on.

Copy link
Collaborator

@AlexandraKemperMS AlexandraKemperMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for catching this change and helping keep our docs up to date!

@gregvanl
Copy link

gregvanl commented May 9, 2023

Adding don't merge label while the C++ extension engineering team has a review.

@gregvanl
Copy link

gregvanl commented Sep 5, 2023

Thank you again @wy-luke for this suggestion.
Now that the C++ extension supports UCRT, the team has submitted #6631 which covers this PR

@gregvanl gregvanl closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants