Skip to content

Freshness pass on C++ docs #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 20, 2023

Conversation

AlexandraKemperMS
Copy link
Collaborator

Updating the C++ docs, for now the MinGW on Windows doc, might add more to this PR or do them as a separate PR.

@isidorn
Copy link
Contributor

isidorn commented Jul 17, 2023

@AlexandraKemperMS there are some conflicts. Once you resolve those and tackle Rob's comments we can merge this in.

@gregvanl
Copy link

@AlexandraKemperMS How does your update align with #6276?
That community PR to update the installation to UCRT was approved but delayed for further engineering team testing.
Should PR #6276 be closed in favor of this refresh?

@AlexandraKemperMS
Copy link
Collaborator Author

@AlexandraKemperMS How does your update align with #6276? That community PR to update the installation to UCRT was approved but delayed for further engineering team testing. Should PR #6276 be closed in favor of this refresh?

Good point, we discussed with the engineering team and it should be fine to add, so I included it in this PR. UCRT is only shipped with Windows 10 or later, so I added an additional question to the troubleshooting section in case users run into issues. Also engineering team might take a look at these doc changes to verify, I shared the link with them.

indent pacman step to try and get numbering to work
@gregvanl
Copy link

@AlexandraKemperMS Let me know when you'd like this merged after the engineering team has a look.

Copy link
Contributor

@michelleangela michelleangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Do no merge yet until the extension is updated to look for the new UCRT path.

@AlexandraKemperMS
Copy link
Collaborator Author

@bobbrow @michelleangela we can wait on adding UCRT until the add the support in the extension, for now we can just release the freshness pass on these docs and add UCRT at a later time.

@gregvanl gregvanl merged commit 5e9c4a3 into microsoft:main Jul 20, 2023
@AlexandraKemperMS AlexandraKemperMS deleted the alkemperFreshnessPass branch January 10, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants