Fix for flickering issue when using a drop overlay #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having problems with flickering (as a few of the other pull requests also call out) when using a translucent overlay div that would cover the dropzone. As soon as the overlay would come out, the dragleave event would fire on the drop zone, and flickering would ensue. What I did was introduce a new element nv-file-drop-curtain that parallels nv-file-over, except it expects to be an overlay over the entire drop area. When in play, the curtain is responsible for for the dragleave event rather than the drop zone.
I haven't tested this with multiple drop areas on a page.