Skip to content

Introduce SetLink on profiles #13223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dmathieu
Copy link
Member

Description

This is part of #13106
It introduces a new SetLink method, which allows setting a sample's link based on a specific dictionary.

Related: #13197

@github-actions github-actions bot requested review from bogdandrutu and dmitryax June 17, 2025 09:16
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.50%. Comparing base (e7b140f) to head (36be095).

Files with missing lines Patch % Lines
pdata/pprofile/links.go 58.33% 7 Missing and 3 partials ⚠️

❌ Your patch check has failed because the patch coverage (62.96%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13223      +/-   ##
==========================================
- Coverage   91.54%   91.50%   -0.05%     
==========================================
  Files         522      524       +2     
  Lines       28955    28982      +27     
==========================================
+ Hits        26508    26520      +12     
- Misses       1931     1942      +11     
- Partials      516      520       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu marked this pull request as ready for review June 17, 2025 10:10
@dmathieu dmathieu requested review from mx-psi and a team as code owners June 17, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant