Introduce SetString on profiles #13225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13225 +/- ##
==========================================
- Coverage 91.54% 91.53% -0.02%
==========================================
Files 522 523 +1
Lines 28955 28967 +12
==========================================
+ Hits 26508 26514 +6
- Misses 1931 1935 +4
- Partials 516 518 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
reviewed
Jun 17, 2025
Comment on lines
+15
to
+16
| // SetString updates a StringTable, adding or providing a value and returns its index. | ||
| func SetString(table pcommon.StringSlice, val string) (int32, error) { |
There was a problem hiding this comment.
LoadOrStore to be consistent with https://pkg.go.dev/sync#Map.LoadOrStore?
There was a problem hiding this comment.
Sure, but then that'd be inconsistent with SetMapping, SetFunction, and SetLink from this project.
Unless you'd prefer I also rename those other ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of #13106
It introduces a new
SetStringmethod, which allows setting string values into the string table, or retrieving their existing index.This doesn't work like the other methods, as string indices aren't always stored on the same attribute. So we can't assign the ID directly.