Change standalone validator to warn FILE variable substitution instead of failure #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value does not exist instead of error out. The environment where it is validating may not be have the file contents yet.
tbarnes-us
reviewed
Sep 13, 2019
| raise ex | ||
| else: | ||
| if validation_result: | ||
| validation_result.add_warning('WLSDPLY-01733', file_path, e.getLocalizedMessage()) |
There was a problem hiding this comment.
Since missing files are fully expected, can this be an Info instead of a Warning? Warnings can be distracting as they imply there's something that should be investigated...
There was a problem hiding this comment.
No, the tool is not only used by the k8s and imagetool. It can be used on premise and other situation
There was a problem hiding this comment.
Then add a third state or check for env var?
There was a problem hiding this comment.
There's a new PR for this change, and a discussion of this topic.
#443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change standalone validator so that if the variable @@file@@ value does not exist, it warns instead of error out. The environment where it is validating may not be have the file contents yet.