Validate fix #443
Validate fix #443
Conversation
… value does not exist instead of error out. The environment where it is validating may not be have the file contents yet.
| sys.exit(CommandLineArgUtil.PROG_WARNING_EXIT_CODE) | ||
| else: | ||
| sys.exit(CommandLineArgUtil.PROG_OK_EXIT_CODE) | ||
|
|
There was a problem hiding this comment.
I think the "lax" method should not have a warning when a FILE reference is missing, and this check would not be necessary. Other opinions?
There was a problem hiding this comment.
agreed. lax means do not check, so I wouldn't warn. you could print an info that it was seen and skipped, but otherwise no warning is necessary.
There was a problem hiding this comment.
Agreed. Info is better when missing files are expected - and the adminstrator has already indicated this via the command line option. The only warnings should be those that may need investigation.
There was a problem hiding this comment.
probably ok, I will print as info level but the exit code is always 0 even if there is warning - I don't know where else or if there is other place for warning code
There was a problem hiding this comment.
I think the exit code should be non-zero when there is a valid warning, but I'm not sure if there are other warnings that will cross up image tool?
There was a problem hiding this comment.
if a warning is found, it should have the CommandLineArgUtil.PROG_WARNING_EXIT_CODE
Jenkinsfile
Outdated
| @@ -1,7 +1,6 @@ | |||
| pipeline { | |||
| agent { | |||
| docker { | |||
| alwaysPull true | |||
There was a problem hiding this comment.
Please revert this change. It was a temporary attempt to get around the OCIR outage.
| sys.exit(CommandLineArgUtil.PROG_WARNING_EXIT_CODE) | ||
| else: | ||
| sys.exit(CommandLineArgUtil.PROG_OK_EXIT_CODE) | ||
|
|
There was a problem hiding this comment.
if a warning is found, it should have the CommandLineArgUtil.PROG_WARNING_EXIT_CODE
|
changes reverted |
No description provided.