Skip to content

Separate io helpers from _libs.lib #19364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

jbrockmendel
Copy link
Member

Avoids overlap with #19360 where possible.

Moved functions are cut/paste verbatim.

I'm open to a better name than io_helpers, just wanted to avoid overlap with the stdlib name "io".

Besides refactoring for its own sake, part of the goal is to get lib down the point where we can merge src/inference back into it; the split file makes it tough to track dependencies, and AFAICT it makes the move towards using cythonize easier.

@jbrockmendel
Copy link
Member Author

Closing to declog CI pipeline.

@codecov
Copy link

codecov bot commented Jan 26, 2018

Codecov Report

Merging #19364 into master will decrease coverage by <.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19364      +/-   ##
==========================================
- Coverage   91.57%   91.56%   -0.01%     
==========================================
  Files         150      150              
  Lines       48705    48706       +1     
==========================================
- Hits        44600    44599       -1     
- Misses       4105     4107       +2
Flag Coverage Δ
#multiple 89.93% <83.33%> (-0.01%) ⬇️
#single 41.72% <83.33%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.5% <100%> (ø) ⬆️
pandas/io/json/normalize.py 96.87% <100%> (ø) ⬆️
pandas/io/formats/format.py 96.24% <100%> (ø) ⬆️
pandas/io/pytables.py 92.45% <83.33%> (ø) ⬆️
pandas/util/testing.py 84.24% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdb9c0...3b273f0. Read the comment docs.

@jbrockmendel jbrockmendel deleted the cumops branch February 4, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant