Skip to content

Fix LiveQuery reconnect #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix LiveQuery reconnect #431

wants to merge 4 commits into from

Conversation

facuparedes
Copy link
Contributor

Hi! This PR fixes LiveQuery reconnect when internet is disconnected. When _setReconnect() was called, it was not execute a reconnection because !_isConnected returned false.

FNPCMDs added 2 commits August 30, 2020 03:42
If state is equal to ConnectivityResult.none, then there is no connection with LiveQuery server (for example when internet is disconnected). _setReconnect function will now retry connection.
If state is equal to ConnectivityResult.none, then there is no connection with LiveQuery server (for example when internet is disconnected). _setReconnect function will now retry connection.
@phillwiggins
Copy link
Member

Great addition. Please can you edit this PR to point at the branch release/1.0.28.

Thanks!

@facuparedes
Copy link
Contributor Author

Great addition. Please can you edit this PR to point at the branch release/1.0.28.

Thanks!

Sure, give me a minute

@facuparedes facuparedes changed the base branch from master to release/1.0.28 August 30, 2020 07:03
@facuparedes
Copy link
Contributor Author

Great addition. Please can you edit this PR to point at the branch release/1.0.28.

Thanks!

PR fails because there is no package:flutter_test. However, I didn't modify pubsec.yaml. Can PR be merged?

Copy link

@byeze byeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phillwiggins
Copy link
Member

There seems to be conflicts with this PR. Please can you resolve.

@facuparedes
Copy link
Contributor Author

There seems to be conflicts with this PR. Please can you resolve.

Sure! I'm going to create a new PR, because I need to update my forked version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants