Fix LiveQuery reconnect #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 5, 2020 00:20
Release/1.0.28
If state is equal to ConnectivityResult.none, then there is no connection with LiveQuery server (for example when internet is disconnected). _setReconnect function will now retry connection.
ConnectivityResult to ParseConnectivityResult
|
Hey, sorry there are some conflicts. The packages have recently been split into 2 libraries, one pure dart, and a flutter module that sits on top. |
added 2 commits
September 5, 2020 20:00
Hey! This PR has no conflicts right now. Can it be merged? |
|
Sorry, I wasn't notified about the changes! That's merged now. Great work.
…On Wed, 9 Sep 2020, 19:04 FNPCMDs, ***@***.***> wrote:
Hey, sorry there are some conflicts.
The packages have recently been split into 2 libraries, one pure dart, and
a flutter module that sits on top.
Hey! This PR has no conflicts right now. Can it be merged?
Greetings !
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#440 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4CPXTDQWOV3MC6MERB3W3SE67RPANCNFSM4Q2G7RGA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #431
Hi! This PR fixes LiveQuery reconnect when internet is disconnected. When _setReconnect() was called, it was not execute a reconnection because !_isConnected returned false.