Dont respect cache headers when $this->respectCacheHeaders=false #19
Conversation
| @@ -89,7 +89,9 @@ protected function isCacheable(ResponseInterface $response) | |||
| if (!in_array($response->getStatusCode(), [200, 203, 300, 301, 302, 404, 410])) { | |||
| return false; | |||
| } | |||
| if ($this->getCacheControlDirective($response, 'no-store') || $this->getCacheControlDirective($response, 'private')) { | |||
| if ($this->respectCacheHeaders && | |||
There was a problem hiding this comment.
I think that this check could be in one return statement.
|
I've updated the PR according to your comments |
|
Actually I meant the first condition as well. 😄 You could set some helper variables (like the status code list). |
|
This could go into a separate method, like |
|
ah. Okey. =) I'll update again and make sure it is readable. |
|
hm, okey. I put it in a variable now since it not reused. |
|
|
||
| return true; | ||
| // If http status code is cachable and if we respect the headers, make sure there is no private cache headers. | ||
| return in_array($response->getStatusCode(), $cachableCodes) && (!$this->respectCacheHeaders || !$privateHeaders); |
There was a problem hiding this comment.
Hm...
Isn't it the same as !($this->respectCacheHeaders && $privateHeaders)
There was a problem hiding this comment.
It is the same according to De Morgan's law. You are correct.
There was a problem hiding this comment.
De Morgan's law
I knew that there is a name for this, but I couldn't recall.
|
Thanks @Nyholm |
Dont respect cache headers when $this->respectCacheHeaders=false
|
Thank you for merging. |
|
|
||
| return true; | ||
| // If http status code is cachable and if we respect the headers, make sure there is no private cache headers. | ||
| return in_array($response->getStatusCode(), $cachableCodes) && !($this->respectCacheHeaders && $privateHeaders); |
There was a problem hiding this comment.
i think the previous code with early returns was more readable. i will do another small PR :-)
No description provided.