Skip to content

improve isCacheable readability #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2015
Merged

improve isCacheable readability #22

merged 3 commits into from
Dec 19, 2015

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Dec 19, 2015

seems we have different ideas of code style. i think this is much more readable than what we did in #19

wdyt?

@sagikazarmark
Copy link
Member

Well, I don't mind after all.

@sagikazarmark
Copy link
Member

@dbu do you have access to the repositories in StyleCI?

@dbu
Copy link
Contributor Author

dbu commented Dec 19, 2015

fixed the styling. seems that the github online editor is not that convenient for clean style...

@sagikazarmark
Copy link
Member

😄

At least it turned out that you do have access to StyleCI which is cool.

@Nyholm
Copy link
Member

Nyholm commented Dec 19, 2015

👍

dbu added a commit that referenced this pull request Dec 19, 2015
improve isCacheable readability
@dbu dbu merged commit 0e49971 into master Dec 19, 2015
@dbu dbu deleted the dbu-patch-1 branch December 19, 2015 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants