This repository was archived by the owner on Oct 4, 2020. It is now read-only.
make type Pure use an empty row instead of rank-2 types #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 from me. @garyb Any thoughts? This can be a minor bump I think, since |
|
Looks good to me, I think it better expresses the intent. Are we sure it won't break things though? 😉 |
|
Pretty sure. I mean, yes code can break, but the subsumption relation definitely holds, so unless users are explicitly asserting type equalities rather than unification, it'll be fine. |
|
It seems like there is consensus that this won't break stuff, and it makes pureST work in combination w/ the pull req on purescript-st. I'm new to this process, do you guys need anything else from me? |
|
Looks good, sorry, I'm just being slow. Could you please run |
|
Ahh yes, my bad |
paf31
added a commit
that referenced
this pull request
Sep 12, 2015
make type Pure use an empty row instead of rank-2 types
|
👍 Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with paf31 in #purescript. When this was originally written there wasn't syntax for an empty row, now there is so let's use it.
I believe it's also correct then to remove the note about rank-2 types from runPure so I've done that, correct me if I'm wrong.
I can't say I have a completely solid grasp on rank-n types or Eff/row types so I'm not certifying the correctness of this, just pushing the buttons based on my understanding of what was discussed in #purescript.