leave off the "| r" in pureST #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed check should be due to the dependency on the linked pull request in purescript-eff. |
|
Seems sensible, I guess this one is a breaking change? Even though it's perhaps how it should have been in the first place. |
|
I don't think this is breaking for the same reason as |
|
Isn't it true that currently |
|
Oh, no, rank2, right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with paf31 in #purescript. This was written the old way to follow the lead of runPure, but now that we have empty row syntax runPure doesn't have to be written that way (see purescript-deprecated/purescript-eff#7) so let's write this type a bit more clearly.
I can't say I have a completely solid grasp on rank-n types or Eff/row types so I'm not certifying the correctness of this, just pushing the buttons based on my understanding of what was discussed in #purescript.