Skip to content

Fix typos in ModelChain error messages #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025

Conversation

RDaxini
Copy link
Member

@RDaxini RDaxini commented Jul 1, 2025

  • Closes Typo in error message #2490
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini RDaxini added this to the v0.13.1 milestone Jul 1, 2025
@RDaxini RDaxini changed the title Fix AOI+other typos in ModelChain Fix typos in ModelChain error messages Jul 1, 2025
@RDaxini
Copy link
Member Author

RDaxini commented Jul 1, 2025

Aside: changing the error messages did not fail the tests. Are we missing some test coverage here, or is this okay?

@cwhanse
Copy link
Member

cwhanse commented Jul 1, 2025

Aside: changing the error messages did not fail the tests. Are we missing some test coverage here, or is this okay?

For get_orientation the test doesn't check the text of the error message. Optional to add that.

For infer_aoi_model the test only checks the first part of the message string. I think this is OK.

Co-authored-by: Kevin Anderson <[email protected]>
@RDaxini
Copy link
Member Author

RDaxini commented Jul 1, 2025

For get_orientation the test doesn't check the text of the error message. Optional to add that.

For infer_aoi_model the test only checks the first part of the message string. I think this is OK.

Makes sense. Unless anyone objects, I'll open a PR later to add a quick test for the get_orientation error message.

@kandersolar kandersolar merged commit 10edc65 into pvlib:main Jul 1, 2025
30 checks passed
@kandersolar
Copy link
Member

Thanks @RDaxini

@RDaxini RDaxini deleted the modelchain_aoi_typo branch July 1, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in error message
3 participants