Skip to content

Fix typos in ModelChain error messages #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions pvlib/modelchain.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
# 'cell_temperature' overrides ModelChain.temperature_model and sets
# ModelChain.cell_temperature to the data. If 'module_temperature' is provided,
# overrides ModelChain.temperature_model with
# pvlib.temperature.sapm_celL_from_module
# pvlib.temperature.sapm_cell_from_module
TEMPERATURE_KEYS = ('module_temperature', 'cell_temperature')

DATA_KEYS = WEATHER_KEYS + POA_KEYS + TEMPERATURE_KEYS
Expand All @@ -46,7 +46,7 @@
# for Flat-Plate Photovoltaic Arrays. SAND85-0330. Albuquerque, NM:
# Sandia National Laboratories. Accessed September 3, 2013:
# http://prod.sandia.gov/techlib/access-control.cgi/1985/850330.pdf
# pvlib python does not implement that model, so use the SAPM instead.
# pvlib-python does not implement that model, so it uses the SAPM instead.
PVWATTS_CONFIG = dict(
dc_model='pvwatts', ac_model='pvwatts', losses_model='pvwatts',
transposition_model='perez', aoi_model='physical',
Expand Down Expand Up @@ -84,7 +84,7 @@ def get_orientation(strategy, **kwargs):
surface_tilt = 0
else:
raise ValueError('invalid orientation strategy. strategy must '
'be one of south_at_latitude, flat,')
'be one of south_at_latitude_tilt, flat,')

return surface_tilt, surface_azimuth

Expand Down Expand Up @@ -162,8 +162,8 @@ class ModelChainResult:
# per DC array information
total_irrad: Optional[PerArray[pd.DataFrame]] = field(default=None)
""" DataFrame (or tuple of DataFrame, one for each array) containing
columns ``'poa_global'``, ``'poa_direct'`` ``'poa_diffuse'``,
``poa_sky_diffuse'``, ``'poa_ground_diffuse'`` (W/m2); see
columns ``'poa_global'``, ``'poa_direct'``, ``'poa_diffuse'``,
``poa_sky_diffuse'``, and ``'poa_ground_diffuse'`` (Wm⁻²); see
:py:func:`~pvlib.irradiance.get_total_irradiance` for details.
"""

Expand All @@ -190,12 +190,12 @@ class ModelChainResult:

cell_temperature: Optional[PerArray[pd.Series]] = field(default=None)
"""Series (or tuple of Series, one for each array) containing cell
temperature (C).
temperature (°C).
"""

effective_irradiance: Optional[PerArray[pd.Series]] = field(default=None)
"""Series (or tuple of Series, one for each array) containing effective
irradiance (W/m2) which is total plane-of-array irradiance adjusted for
irradiance (Wm⁻²) which is total plane-of-array irradiance adjusted for
reflections and spectral content.
"""

Expand All @@ -215,12 +215,12 @@ class ModelChainResult:

dc_ohmic_losses: Optional[PerArray[pd.Series]] = field(default=None)
"""Series (or tuple of Series, one for each array) containing DC ohmic
loss (W) calculated by ``ModelChain.dc_ohmic_model``.
losses (W) calculated by ``ModelChain.dc_ohmic_model``.
"""

# copies of input data, for user convenience
weather: Optional[PerArray[pd.DataFrame]] = None
"""DataFrame (or tuple of DataFrame, one for each array) contains a
"""DataFrame (or tuple of DataFrame, one for each array) containing a
copy of the input weather data.
"""

Expand Down Expand Up @@ -806,7 +806,7 @@ def infer_aoi_model(self):
'system.arrays[i].module_parameters. Check that '
'the module_parameters for all Arrays in '
'system.arrays contain parameters for the '
'physical, aoi, ashrae, martin_ruiz or interp '
'physical, sapm, ashrae, martin_ruiz or interp '
'model; explicitly set the model with the '
'aoi_model kwarg; or set aoi_model="no_loss".')

Expand Down
Loading