gh-135571: Guard _hashlib usage in test_hashlib.py #135572
Open
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillChilds-Klein
requested review from
gpshead,
tiran and
picnixz
as code owners
picnixz
reviewed
Jun 16, 2025
zware
changed the title
Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
approved these changes
Jun 22, 2025
| # Make sure that _hashlib contains the constructor | ||
| # to test when using a combination of libcrypto and | ||
| # interned hash implementations. | ||
| if self._hashlib and digest_name in self._hashlib._constructors: |
There was a problem hiding this comment.
For now, this seems the correct way to guard it but there are other places where we do self._hashlib.new('md5') and this works because all libcrypto libs actually expose 'md5'. Id assume that the issue is with blake2 right? or is it another hash function that is causing the issue?
There was a problem hiding this comment.
In terms of hash functions provided by hashlib, the only gap I'm aware of between OpenSSL and (some) other libcryptos is BLAKE2.
There was a problem hiding this comment.
Ok to merge @picnixz?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
See here.
Testing
See here.