Skip to content

gh-135571: Guard _hashlib usage in test_hashlib.py #135572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
+6 −2
Merged

gh-135571: Guard _hashlib usage in test_hashlib.py #135572

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ace9af
Guard _hahslib usage in test_hashlib.py
WillChilds-Klein Jun 16, 2025
1dda3b6
Update Lib/test/test_hashlib.py
WillChilds-Klein Jun 16, 2025
27ca72f
Update test_clinic_signature_errors
WillChilds-Klein Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Lib/test/test_hashlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,10 @@ def test_clinic_signature(self):
with self.assertWarnsRegex(DeprecationWarning,
DEPRECATED_STRING_PARAMETER):
hashlib.new(digest_name, string=b'')
if self._hashlib:
# Make sure that _hashlib contains the constructor
# to test when using a combination of libcrypto and
# interned hash implementations.
if self._hashlib and digest_name in self._hashlib._constructors:
self._hashlib.new(digest_name, b'')
self._hashlib.new(digest_name, data=b'')
with self.assertWarnsRegex(DeprecationWarning,
Expand Down Expand Up @@ -328,7 +331,8 @@ def test_clinic_signature_errors(self):
with self.subTest(digest_name, args=args, kwds=kwds):
with self.assertRaisesRegex(TypeError, errmsg):
hashlib.new(digest_name, *args, **kwds)
if self._hashlib:
if (self._hashlib and
digest_name in self._hashlib._constructors):
with self.assertRaisesRegex(TypeError, errmsg):
self._hashlib.new(digest_name, *args, **kwds)

Expand Down
Loading